You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ptgoetz <gi...@git.apache.org> on 2016/04/28 19:00:31 UTC
[GitHub] storm pull request: STORM-1741: remove unconditional setting of JA...
GitHub user ptgoetz opened a pull request:
https://github.com/apache/storm/pull/1377
STORM-1741: remove unconditional setting of JAVA_HOME from storm-env.sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/storm STORM-1741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1377
----
commit 862e468c3bbf632e9ed1e6efc204ef69e55af55f
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-04-28T16:58:44Z
remove unconditional setting of JAVA_HOME from storm-env.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1741: remove unconditional setting of JA...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1741: remove unconditional setting of JA...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on the pull request:
https://github.com/apache/storm/pull/1377#issuecomment-215852916
Merge away! Thanks for the update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1741: remove unconditional setting of JA...
Posted by abhishekagarwal87 <gi...@git.apache.org>.
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1377#issuecomment-215856040
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1741: remove unconditional setting of JA...
Posted by erikdw <gi...@git.apache.org>.
Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/1377#discussion_r61466360
--- Diff: conf/storm-env.sh ---
@@ -19,6 +19,6 @@
# Set Storm specific environment variables here.
# The java implementation to use.
-export JAVA_HOME=${JAVA_HOME}
+#export JAVA_HOME=${JAVA_HOME}
--- End diff --
Maybe leave a comment about why dead code is being left here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1741: remove unconditional setting of JA...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1377#issuecomment-215792468
As this is a very minor change that fixes a blocker, if there are no objections I will merge it in order to proceed with the 1.0.1 rc3 release.
If there are any objections after the fact, we can cancel the release and revert the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---