You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by de...@geronimo.apache.org on 2004/10/18 01:13:51 UTC
[jira] Created: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/GERONIMO-383
Here is an overview of the issue:
---------------------------------------------------------------------
Key: GERONIMO-383
Summary: xmlbeans magic allows us to accept some invalid deployment descriptors
Type: Bug
Status: Unassigned
Priority: Major
Project: Apache Geronimo
Versions:
1.0-M2
Assignee:
Reporter: David Jencks
Created: Sun, 17 Oct 2004 4:12 PM
Updated: Sun, 17 Oct 2004 4:12 PM
Description:
The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
1. look for the DOCTYPE using xmlbeans
2. converting to a made-up namespace for that dtd
3. validating against xmlbeans objects for the schema corresponding to the dtd.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-383?page=comments#action_12357352 ]
Matt Hogstrom commented on GERONIMO-383:
----------------------------------------
David, is this still an issue since the conversion to XMLBeans 2?
> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
> Key: GERONIMO-383
> URL: http://issues.apache.org/jira/browse/GERONIMO-383
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 1.x
>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-383?page=all ]
Aaron Mulder updated GERONIMO-383:
----------------------------------
Fix Version: 1.0
Description:
The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
1. look for the DOCTYPE using xmlbeans
2. converting to a made-up namespace for that dtd
3. validating against xmlbeans objects for the schema corresponding to the dtd.
was:
The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
1. look for the DOCTYPE using xmlbeans
2. converting to a made-up namespace for that dtd
3. validating against xmlbeans objects for the schema corresponding to the dtd.
Environment:
> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
> Key: GERONIMO-383
> URL: http://issues.apache.org/jira/browse/GERONIMO-383
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 1.0
>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-383?page=all ]
David Jencks updated GERONIMO-383:
----------------------------------
Fix Version: 1.x
(was: 1.0)
> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
> Key: GERONIMO-383
> URL: http://issues.apache.org/jira/browse/GERONIMO-383
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 1.x
>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-383?page=comments#action_58619 ]
David Jencks commented on GERONIMO-383:
---------------------------------------
Progress towards this goal, mostly in rev 151477 and 151327.
All builders now assume a file with the correct name to be their dd is their dd, and throw an exception if they can't parse it. This should fix most of the mysterious "Syntax error or no deployer found" erros.
Ejb dd parsing now checks for the 1.4 namespace and does not munge if present, and checks that a dtd is one of the two legal possibilities.
> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
> Key: GERONIMO-383
> URL: http://issues.apache.org/jira/browse/GERONIMO-383
> Project: Apache Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: David Jencks
> Assignee: David Jencks
>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by de...@geronimo.apache.org.
The following issue has been updated:
Updater: David Jencks (mailto:djencks@apache.org)
Date: Sun, 24 Oct 2004 11:25 AM
Changes:
assignee changed to David Jencks
Component changed to deployment
---------------------------------------------------------------------
For a full history of the issue, see:
http://issues.apache.org/jira/browse/GERONIMO-383?page=history
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/GERONIMO-383
Here is an overview of the issue:
---------------------------------------------------------------------
Key: GERONIMO-383
Summary: xmlbeans magic allows us to accept some invalid deployment descriptors
Type: Bug
Status: Open
Priority: Major
Project: Apache Geronimo
Components:
deployment
Versions:
1.0-M2
Assignee: David Jencks
Reporter: David Jencks
Created: Sun, 17 Oct 2004 4:12 PM
Updated: Sun, 24 Oct 2004 11:25 AM
Description:
The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
1. look for the DOCTYPE using xmlbeans
2. converting to a made-up namespace for that dtd
3. validating against xmlbeans objects for the schema corresponding to the dtd.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-383) xmlbeans magic allows us to accept
some invalid deployment descriptors
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-383?page=all ]
David Jencks updated GERONIMO-383:
----------------------------------
Fix Version/s: Wish List
(was: 1.x)
Assignee: (was: David Jencks)
I doubt I will have time to look into this in the forseeable future.
> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
> Key: GERONIMO-383
> URL: http://issues.apache.org/jira/browse/GERONIMO-383
> Project: Geronimo
> Issue Type: Bug
> Components: deployment
> Affects Versions: 1.0-M2
> Reporter: David Jencks
> Fix For: Wish List
>
>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by David Jencks <da...@yahoo.com>.
On Nov 11, 2005, at 7:06 AM, Matt Hogstrom wrote:
> I put this in 1.x as a target. Does this need to be a 1.0 item?
I don't think so. I doubt very many people will complain if we
successfully deploy their app even if it has a broken pre-j2ee-1.4
deployment descriptor.
thanks
david jencks
>
> David Jencks (JIRA) wrote:
>> [
>> http://issues.apache.org/jira/browse/GERONIMO-383?
>> page=comments#action_12357365 ] David Jencks commented on
>> GERONIMO-383:
>> ---------------------------------------
>> yes, this area needs a thorough review to make sure we are validating
>> pre-j2ee 1.4 descriptors properly before converting them to j2ee 1.4
>> descriptors. I believe there are still quite a few unvalidated
>> cases.
>>> xmlbeans magic allows us to accept some invalid deployment
>>> descriptors
>>> ---------------------------------------------------------------------
>>> -
>>>
>>> Key: GERONIMO-383
>>> URL: http://issues.apache.org/jira/browse/GERONIMO-383
>>> Project: Geronimo
>>> Type: Bug
>>> Components: deployment
>>> Versions: 1.0-M2
>>> Reporter: David Jencks
>>> Assignee: David Jencks
>>> Fix For: 1.x
>>> The element reordering and other xmlbeans magic we do to convert
>>> pre-1.4 deployment descriptors to 1.4 versions can have the
>>> unintended side effect of converting invalid 1.4 descriptors to
>>> valid ones. This has been fixed in SchemaConversionUtils.conv
> ertToServletSchema for servlet 1.3 web.xml. We should apply this same
> fix of checking for namespace before conversion to other modules (ejb
> etc) and extend the checking to:
>>> 1. look for the DOCTYPE using xmlbeans
>>> 2. converting to a made-up namespace for that dtd
>>> 3. validating against xmlbeans objects for the schema corresponding
>>> to the dtd.
>
Re: [jira] Commented: (GERONIMO-383) xmlbeans magic allows us to
accept some invalid deployment descriptors
Posted by Matt Hogstrom <ma...@hogstrom.org>.
I put this in 1.x as a target. Does this need to be a 1.0 item?
David Jencks (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/GERONIMO-383?page=comments#action_12357365 ]
>
> David Jencks commented on GERONIMO-383:
> ---------------------------------------
>
> yes, this area needs a thorough review to make sure we are validating pre-j2ee 1.4 descriptors properly before converting them to j2ee 1.4 descriptors. I believe there are still quite a few unvalidated cases.
>
>>xmlbeans magic allows us to accept some invalid deployment descriptors
>>----------------------------------------------------------------------
>>
>> Key: GERONIMO-383
>> URL: http://issues.apache.org/jira/browse/GERONIMO-383
>> Project: Geronimo
>> Type: Bug
>> Components: deployment
>> Versions: 1.0-M2
>> Reporter: David Jencks
>> Assignee: David Jencks
>> Fix For: 1.x
>
>>The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.conv
ertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
>>1. look for the DOCTYPE using xmlbeans
>>2. converting to a made-up namespace for that dtd
>>3. validating against xmlbeans objects for the schema corresponding to the dtd.
>
[jira] Commented: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-383?page=comments#action_12357365 ]
David Jencks commented on GERONIMO-383:
---------------------------------------
yes, this area needs a thorough review to make sure we are validating pre-j2ee 1.4 descriptors properly before converting them to j2ee 1.4 descriptors. I believe there are still quite a few unvalidated cases.
> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
> Key: GERONIMO-383
> URL: http://issues.apache.org/jira/browse/GERONIMO-383
> Project: Geronimo
> Type: Bug
> Components: deployment
> Versions: 1.0-M2
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 1.x
>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors to valid ones. This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet 1.3 web.xml. We should apply this same fix of checking for namespace before conversion to other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira