You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (Created) (JIRA)" <ji...@apache.org> on 2012/02/01 01:58:56 UTC

[jira] [Created] (HBASE-5310) HConnectionManager cache server name enhancement

HConnectionManager cache server name enhancement
------------------------------------------------

                 Key: HBASE-5310
                 URL: https://issues.apache.org/jira/browse/HBASE-5310
             Project: HBase
          Issue Type: Improvement
          Components: client
    Affects Versions: 0.94.0
            Reporter: Jimmy Xiang
            Assignee: Jimmy Xiang
            Priority: Minor
             Fix For: 0.94.0
         Attachments: hbase-5310.txt

HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.

It should be better to use HRegionLocation.getHostnamePort() instead.

In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5310) HConnectionManager cache server name enhancement

Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-5310:
-------------------------------

    Attachment: hbase-5310.txt
    
> HConnectionManager cache server name enhancement
> ------------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5310) HConnectionManager cache server name enhancement

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197490#comment-13197490 ] 

Hadoop QA commented on HBASE-5310:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12512705/hbase-5310.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -140 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestHFileBlock

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/884//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/884//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/884//console

This message is automatically generated.
                
> HConnectionManager cache server name enhancement
> ------------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5310) HConnectionManager server cache key enhancement

Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Yu updated HBASE-5310:
------------------------------

         Summary: HConnectionManager server cache key enhancement  (was: HConnectionManager cache server name enhancement)
    Hadoop Flags: Reviewed

Integrated to TRUNK.

Thanks for the patch Jimmy
                
> HConnectionManager server cache key enhancement
> -----------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5310) HConnectionManager server cache key enhancement

Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197984#comment-13197984 ] 

Jimmy Xiang commented on HBASE-5310:
------------------------------------

@Ted, thanks for review and integration.
                
> HConnectionManager server cache key enhancement
> -----------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5310) HConnectionManager server cache key enhancement

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198086#comment-13198086 ] 

Hudson commented on HBASE-5310:
-------------------------------

Integrated in HBase-TRUNK #2650 (See [https://builds.apache.org/job/HBase-TRUNK/2650/])
    HBASE-5310 HConnectionManager server cache key enhancement (Jimmy Xiang)

tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java

                
> HConnectionManager server cache key enhancement
> -----------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5310) HConnectionManager cache server name enhancement

Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-5310:
-------------------------------

    Status: Patch Available  (was: Open)
    
> HConnectionManager cache server name enhancement
> ------------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5310) HConnectionManager server cache key enhancement

Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-5310:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> HConnectionManager server cache key enhancement
> -----------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5310) HConnectionManager cache server name enhancement

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197486#comment-13197486 ] 

Zhihong Yu commented on HBASE-5310:
-----------------------------------

Patch looks good to me.
                
> HConnectionManager cache server name enhancement
> ------------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira