You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/10/03 17:23:15 UTC
[GitHub] iainconnor opened a new pull request #275: CB-14190: (windows) Fix
bug where double clicking `
iainconnor opened a new pull request #275: CB-14190: (windows) Fix bug where double clicking `<select>` exits app
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275
Double clicking on `<select>` elements will no longer exit the application.
### Platforms affected
* Windows.
### What does this PR do?
Previously, there was code which I assume was meant to detect a click outside the webview (and on the browser wrapper), and close the webview if such a click occurs. This makes sense if the webview is treated like a popup, but the code did not check if the target of the click was the webview itself. For whatever reason, double clicking a `<select>` element triggered this behaviour, incorrectly closing the webview when the user is trying to interact with it.
### What testing has been done on this change?
* Tested that double clicking a `<select>` element no longer triggers the exit event.
* Tested that a non-fullscreen inappbrowser still triggers the exit event if clicked outside of.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org