You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2018/03/08 00:31:20 UTC

[Impala-ASF-CR] Fix test dimensions in test errorlog.py 

Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9546


Change subject: Fix test dimensions in test_errorlog.py
......................................................................

Fix test dimensions in test_errorlog.py

Bug: The test dimensions were set up such that
the test ran for all text-format variants
(including compressed text)

The test is file-format independent and slow (>40s),
so we should only run it once.

Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
---
M tests/query_test/test_errorlog.py
1 file changed, 6 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/9546/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................

Fix test dimensions in test_errorlog.py

Bug: The test dimensions were set up such that
the test ran for all text-format variants
(including compressed text)

The test is file-format independent and slow (>40s),
so we should only run it once.

Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Reviewed-on: http://gerrit.cloudera.org:8080/9546
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/query_test/test_errorlog.py
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Alex Behm: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9546

to look at the new patch set (#2).

Change subject: Fix test dimensions in test_errorlog.py
......................................................................

Fix test dimensions in test_errorlog.py

Bug: The test dimensions were set up such that
the test ran for all text-format variants
(including compressed text)

The test is file-format independent and slow (>40s),
so we should only run it once.

Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
---
M tests/query_test/test_errorlog.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/9546/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2079/


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 21:44:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2074/


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 17:13:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9546/1/tests/query_test/test_errorlog.py
File tests/query_test/test_errorlog.py:

http://gerrit.cloudera.org:8080/#/c/9546/1/tests/query_test/test_errorlog.py@40
PS1, Line 40:       create_uncompressed_text_dimension(cls.get_workload()))
> nit: indent 4 spaces
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:51:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9546

to look at the new patch set (#3).

Change subject: Fix test dimensions in test_errorlog.py
......................................................................

Fix test dimensions in test_errorlog.py

Bug: The test dimensions were set up such that
the test ran for all text-format variants
(including compressed text)

The test is file-format independent and slow (>40s),
so we should only run it once.

Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
---
M tests/query_test/test_errorlog.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/9546/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:16:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2074/


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 20:54:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Mar 2018 01:33:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 17:10:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:52:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9546/1/tests/query_test/test_errorlog.py
File tests/query_test/test_errorlog.py:

http://gerrit.cloudera.org:8080/#/c/9546/1/tests/query_test/test_errorlog.py@40
PS1, Line 40:       create_uncompressed_text_dimension(cls.get_workload()))
nit: indent 4 spaces



-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 02:16:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 )

Change subject: Fix test dimensions in test_errorlog.py
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73
Gerrit-Change-Number: 9546
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 16:26:13 +0000
Gerrit-HasComments: No