You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/09 03:48:58 UTC

[GitHub] [incubator-inlong] kipshi opened a new pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

kipshi opened a new pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412


   ### Title Name: [INLONG-XYZ][component] Title of the pull request
   
   where *XYZ* should be replaced by the actual issue number.
   
   Fixes #2410 
   
   ### Motivation
   
   * Application group doesn't support suspend and restart
   
   ### Modifications
   
   * use workflow engine to suspend | restart | delete application group resources
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a change in pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412#discussion_r802327758



##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/BusinessController.java
##########
@@ -86,7 +86,8 @@
     @OperationLog(operation = OperationType.DELETE)
     @ApiImplicitParam(name = "groupId", value = "Business group id", dataTypeClass = String.class, required = true)
     public Response<Boolean> delete(@PathVariable String groupId) {
-        return Response.success(businessService.delete(groupId, LoginUserUtil.getLoginUserDetail().getUserName()));
+        return Response.success(bizProcessOperation.deleteProcess(groupId, 

Review comment:
       OK, in `deleteProcess` method, logically delete business info.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang merged pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a change in pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412#discussion_r802261807



##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/BusinessController.java
##########
@@ -86,7 +86,8 @@
     @OperationLog(operation = OperationType.DELETE)
     @ApiImplicitParam(name = "groupId", value = "Business group id", dataTypeClass = String.class, required = true)
     public Response<Boolean> delete(@PathVariable String groupId) {
-        return Response.success(businessService.delete(groupId, LoginUserUtil.getLoginUserDetail().getUserName()));
+        return Response.success(bizProcessOperation.deleteProcess(groupId, 

Review comment:
       It is recommended to distinguish between deleting data and deleting processes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] kipshi commented on a change in pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

Posted by GitBox <gi...@apache.org>.
kipshi commented on a change in pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412#discussion_r802280036



##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/BusinessController.java
##########
@@ -86,7 +86,8 @@
     @OperationLog(operation = OperationType.DELETE)
     @ApiImplicitParam(name = "groupId", value = "Business group id", dataTypeClass = String.class, required = true)
     public Response<Boolean> delete(@PathVariable String groupId) {
-        return Response.success(businessService.delete(groupId, LoginUserUtil.getLoginUserDetail().getUserName()));
+        return Response.success(bizProcessOperation.deleteProcess(groupId, 

Review comment:
       BusinessProcessOperation will invoke BusinessService to logically delete data, I think data changing should all lay up cohensively in BusinessService, and repository class should not be invoked directly by other classes;




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2412: [INLONG-2410] Inlong Manager support business workflow suspend | restart | delete

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2412:
URL: https://github.com/apache/incubator-inlong/pull/2412#issuecomment-1033326235


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2412](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ef1328) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/32e66a8d93915daf3b6def4ff78fca44355574fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32e66a8) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/2412/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2412      +/-   ##
   ============================================
   - Coverage     12.55%   12.54%   -0.01%     
   + Complexity     1221     1219       -2     
   ============================================
     Files           420      420              
     Lines         36240    36240              
     Branches       5670     5670              
   ============================================
   - Hits           4550     4547       -3     
   - Misses        30884    30886       +2     
   - Partials        806      807       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../inlong/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-inlong/pull/2412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `38.88% <0.00%> (-1.12%)` | :arrow_down: |
   | [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-inlong/pull/2412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `34.07% <0.00%> (-0.45%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32e66a8...5ef1328](https://codecov.io/gh/apache/incubator-inlong/pull/2412?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org