[GitHub] [geode] DonalEvans commented on pull request #5832: GEODE-8778: Change conserve-sockets default value to false

[GitBox <gi...@apache.org>]

DonalEvans commented on pull request #5832:
URL: https://github.com/apache/geode/pull/5832#issuecomment-742069511


   > Why are the two tests modified in this PR setting the the value against the new default? If the default is `false` now it stands to reason that unless a tests is explicitly testing socket conservation that it should use the new default of `false`.
   
   Thanks for bringing this up, Jake. After looking closer at the first test, `ClusterDistributionManagerDUnitTest`, it doesn't need to explicitly set conserve-sockets to true, just add an additional ignored exception due to a slightly different code path resulting in (expected) logging about `ack-severe-alert-threshold` being exceeded. I've modified the test to reflect this.
   
   The second test, `CloseConnectionTest` is explicitly testing the behaviour of shared connections, so it requires that conserve-sockets=true. I think it was just an oversight to not set the value and instead rely on the default.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org