You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seatunnel.apache.org by Lucifer Tyrant <ty...@apache.org> on 2022/12/24 15:54:43 UTC
[Disscuss] Add config check logic for connector v2
Hi community,
As we know, we had done the work of upgrading connector v2, but some
features also did't be developed. This mail I want to discuss with your
guys about config check logic implementation.
In order to do this feature, we should add a new method *checkConfig
*in *SeaTunnelPluginLifeCycle,
*and invoke it in starter module.
For more details, you can see this pull request:
https://github.com/apache/incubator-seatunnel/pull/3800
If you have any other good ideas, please let me know and reply this email.
Best wishes
Chao Tian
Re: [Disscuss] Add config check logic for connector v2
Posted by Lucifer Tyrant <ty...@apache.org>.
Hi Zongwen,
Thanks for your reminder. In this change, I think it's a good chance
to enable OptionRule api in connectors v2, I will write clear examples
to guide developers in using the new api verify config file.
Best wishes!
Chao Tian
Zongwen Li <zo...@apache.org> 于2022年12月27日周二 21:18写道：
>
> I think the use of Factory#optionRule can be recommended.
>
> JUN GAO <ga...@apache.org> 于2022年12月27日周二 21:11写道：
> >
> > +1
> >
> > hailin0 <wa...@apache.org> 于2022年12月27日周二 20:35写道：
> >
> > > +1,That's great
> > >
> > > Leonard（Lifeng Nie） <ni...@apache.org> 于2022年12月26日周一 17:49写道：
> > >
> > > > +1,That's great
> > > >
> > > > Jia Fan <fa...@qq.com.invalid> 于2022年12月26日周一 10:46写道：
> > > >
> > > > > +1, we need some method to make sure config are right before run it.
> > > > > ________________________
> > > > >
> > > > > Jia Fan
> > > > >
> > > > >
> > > > >
> > > > > > 2022年12月24日 23:54，Lucifer Tyrant <ty...@apache.org> 写道：
> > > > > >
> > > > > > Hi community,
> > > > > >
> > > > > > As we know, we had done the work of upgrading connector v2, but some
> > > > > > features also did't be developed. This mail I want to discuss with
> > > your
> > > > > > guys about config check logic implementation.
> > > > > >
> > > > > > In order to do this feature, we should add a new method *checkConfig
> > > > > > *in *SeaTunnelPluginLifeCycle,
> > > > > > *and invoke it in starter module.
> > > > > >
> > > > > > For more details, you can see this pull request:
> > > > > >
> > > > > > https://github.com/apache/incubator-seatunnel/pull/3800
> > > > > >
> > > > > > If you have any other good ideas, please let me know and reply this
> > > > > email.
> > > > > >
> > > > > > Best wishes
> > > > > > Chao Tian
> > > > >
> > > > >
> > > >
> > > > --
> > > > Warm Regards,
> > > >
> > > > Leonard（LiFeng Nie）
> > > >
> > >
> >
> >
> > --
> >
> > Best Regards
> >
> > ------------
> >
> > EricJoy2048
> > gaojun2048@gmail.com
>
>
>
> --
> Best Regards,
>
> Zongwen Li
Re: [Disscuss] Add config check logic for connector v2
Posted by Zongwen Li <zo...@apache.org>.
I think the use of Factory#optionRule can be recommended.
JUN GAO <ga...@apache.org> 于2022年12月27日周二 21:11写道：
>
> +1
>
> hailin0 <wa...@apache.org> 于2022年12月27日周二 20:35写道：
>
> > +1,That's great
> >
> > Leonard（Lifeng Nie） <ni...@apache.org> 于2022年12月26日周一 17:49写道：
> >
> > > +1,That's great
> > >
> > > Jia Fan <fa...@qq.com.invalid> 于2022年12月26日周一 10:46写道：
> > >
> > > > +1, we need some method to make sure config are right before run it.
> > > > ________________________
> > > >
> > > > Jia Fan
> > > >
> > > >
> > > >
> > > > > 2022年12月24日 23:54，Lucifer Tyrant <ty...@apache.org> 写道：
> > > > >
> > > > > Hi community,
> > > > >
> > > > > As we know, we had done the work of upgrading connector v2, but some
> > > > > features also did't be developed. This mail I want to discuss with
> > your
> > > > > guys about config check logic implementation.
> > > > >
> > > > > In order to do this feature, we should add a new method *checkConfig
> > > > > *in *SeaTunnelPluginLifeCycle,
> > > > > *and invoke it in starter module.
> > > > >
> > > > > For more details, you can see this pull request:
> > > > >
> > > > > https://github.com/apache/incubator-seatunnel/pull/3800
> > > > >
> > > > > If you have any other good ideas, please let me know and reply this
> > > > email.
> > > > >
> > > > > Best wishes
> > > > > Chao Tian
> > > >
> > > >
> > >
> > > --
> > > Warm Regards,
> > >
> > > Leonard（LiFeng Nie）
> > >
> >
>
>
> --
>
> Best Regards
>
> ------------
>
> EricJoy2048
> gaojun2048@gmail.com
--
Best Regards,
Zongwen Li
Re: [Disscuss] Add config check logic for connector v2
Posted by JUN GAO <ga...@apache.org>.
+1
hailin0 <wa...@apache.org> 于2022年12月27日周二 20:35写道：
> +1,That's great
>
> Leonard（Lifeng Nie） <ni...@apache.org> 于2022年12月26日周一 17:49写道：
>
> > +1,That's great
> >
> > Jia Fan <fa...@qq.com.invalid> 于2022年12月26日周一 10:46写道：
> >
> > > +1, we need some method to make sure config are right before run it.
> > > ________________________
> > >
> > > Jia Fan
> > >
> > >
> > >
> > > > 2022年12月24日 23:54，Lucifer Tyrant <ty...@apache.org> 写道：
> > > >
> > > > Hi community,
> > > >
> > > > As we know, we had done the work of upgrading connector v2, but some
> > > > features also did't be developed. This mail I want to discuss with
> your
> > > > guys about config check logic implementation.
> > > >
> > > > In order to do this feature, we should add a new method *checkConfig
> > > > *in *SeaTunnelPluginLifeCycle,
> > > > *and invoke it in starter module.
> > > >
> > > > For more details, you can see this pull request:
> > > >
> > > > https://github.com/apache/incubator-seatunnel/pull/3800
> > > >
> > > > If you have any other good ideas, please let me know and reply this
> > > email.
> > > >
> > > > Best wishes
> > > > Chao Tian
> > >
> > >
> >
> > --
> > Warm Regards,
> >
> > Leonard（LiFeng Nie）
> >
>
--
Best Regards
------------
EricJoy2048
gaojun2048@gmail.com
Re: [Disscuss] Add config check logic for connector v2
Posted by hailin0 <wa...@apache.org>.
+1,That's great
Leonard（Lifeng Nie） <ni...@apache.org> 于2022年12月26日周一 17:49写道：
> +1,That's great
>
> Jia Fan <fa...@qq.com.invalid> 于2022年12月26日周一 10:46写道：
>
> > +1, we need some method to make sure config are right before run it.
> > ________________________
> >
> > Jia Fan
> >
> >
> >
> > > 2022年12月24日 23:54，Lucifer Tyrant <ty...@apache.org> 写道：
> > >
> > > Hi community,
> > >
> > > As we know, we had done the work of upgrading connector v2, but some
> > > features also did't be developed. This mail I want to discuss with your
> > > guys about config check logic implementation.
> > >
> > > In order to do this feature, we should add a new method *checkConfig
> > > *in *SeaTunnelPluginLifeCycle,
> > > *and invoke it in starter module.
> > >
> > > For more details, you can see this pull request:
> > >
> > > https://github.com/apache/incubator-seatunnel/pull/3800
> > >
> > > If you have any other good ideas, please let me know and reply this
> > email.
> > >
> > > Best wishes
> > > Chao Tian
> >
> >
>
> --
> Warm Regards,
>
> Leonard（LiFeng Nie）
>
Re: [Disscuss] Add config check logic for connector v2
Posted by Leonard（Lifeng Nie） <ni...@apache.org>.
+1,That's great
Jia Fan <fa...@qq.com.invalid> 于2022年12月26日周一 10:46写道：
> +1, we need some method to make sure config are right before run it.
> ________________________
>
> Jia Fan
>
>
>
> > 2022年12月24日 23:54，Lucifer Tyrant <ty...@apache.org> 写道：
> >
> > Hi community,
> >
> > As we know, we had done the work of upgrading connector v2, but some
> > features also did't be developed. This mail I want to discuss with your
> > guys about config check logic implementation.
> >
> > In order to do this feature, we should add a new method *checkConfig
> > *in *SeaTunnelPluginLifeCycle,
> > *and invoke it in starter module.
> >
> > For more details, you can see this pull request:
> >
> > https://github.com/apache/incubator-seatunnel/pull/3800
> >
> > If you have any other good ideas, please let me know and reply this
> email.
> >
> > Best wishes
> > Chao Tian
>
>
--
Warm Regards,
Leonard（LiFeng Nie）
Re: [Disscuss] Add config check logic for connector v2
Posted by Jia Fan <fa...@qq.com.INVALID>.
+1, we need some method to make sure config are right before run it.
________________________
Jia Fan
> 2022年12月24日 23:54，Lucifer Tyrant <ty...@apache.org> 写道：
>
> Hi community,
>
> As we know, we had done the work of upgrading connector v2, but some
> features also did't be developed. This mail I want to discuss with your
> guys about config check logic implementation.
>
> In order to do this feature, we should add a new method *checkConfig
> *in *SeaTunnelPluginLifeCycle,
> *and invoke it in starter module.
>
> For more details, you can see this pull request:
>
> https://github.com/apache/incubator-seatunnel/pull/3800
>
> If you have any other good ideas, please let me know and reply this email.
>
> Best wishes
> Chao Tian