You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2021/07/16 15:32:39 UTC

Re: [wicket] branch wicket-9.x-with-jpms updated (d0b8d69 -> a101808)

Hello All,

Maybe we can set-up `apache-rat-plugin` plugin to check the licence headers
and drop all these ApacheLicenceHeaderTest.java?

On Fri, 16 Jul 2021 at 20:29, <mg...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> mgrigorov pushed a change to branch wicket-9.x-with-jpms
> in repository https://gitbox.apache.org/repos/asf/wicket.git.
>
>
>     from d0b8d69  WICKET-6903 Replace maven-clirr-plugin with something
> newer
>      add a101808  WICKET-6904 Make Apache Wicket fully supporting Java9+
> module system
>
> No new revisions were added by this update.
>
> Summary of changes:
>  wicket-experimental/wicket-http2/pom.xml           | 11 +++++++
>  .../src/main/java/module-info.java                 |  9 +++---
>  .../util/license/ApacheLicenceHeaderTest.java      |  2 +-
>  .../util/license/ApacheLicenceHeaderTest.java      | 34
> ----------------------
>  .../wicket-http2/wicket-http2-jetty/pom.xml        |  4 +++
>  .../src/main/java/module-info.java                 | 11 ++++---
>  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
>  .../util/license/ApacheLicenceHeaderTest.java      | 34
> ----------------------
>  .../src/main/java/module-info.java                 | 10 +++----
>  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
>  .../util/license/ApacheLicenceHeaderTest.java      | 34
> ----------------------
>  .../wicket-http2/wicket-http2-tomcat/pom.xml       |  4 +++
>  .../src/main/java/module-info.java                 | 11 ++++---
>  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
>  .../util/license/ApacheLicenceHeaderTest.java      | 34
> ----------------------
>  .../wicket-http2/wicket-http2-undertow/pom.xml     |  4 +++
>  .../src/main/java/module-info.java                 | 11 ++++---
>  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
>  .../util/license/ApacheLicenceHeaderTest.java      | 34
> ----------------------
>  19 files changed, 53 insertions(+), 206 deletions(-)
>  copy {wicket-velocity =>
> wicket-experimental/wicket-http2/wicket-http2-core}/src/main/java/module-info.java
> (85%)
>  copy {wicket-extensions/src/test/java/org/apache/wicket/extensions =>
> wicket-experimental/wicket-http2/wicket-http2-core/src/test/java/org/apache/wicket/http2/markup}/util/license/ApacheLicenceHeaderTest.java
> (96%)
>  delete mode 100644
> wicket-experimental/wicket-http2/wicket-http2-core/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
>  copy {wicket-native-websocket/wicket-native-websocket-javax =>
> wicket-experimental/wicket-http2/wicket-http2-jetty}/src/main/java/module-info.java
> (81%)
>  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> wicket-experimental/wicket-http2/wicket-http2-jetty/src/test/java/org/apache/wicket/http2/markup/head/jetty}/util/license/ApacheLicenceHeaderTest.java
> (95%)
>  delete mode 100644
> wicket-experimental/wicket-http2/wicket-http2-jetty/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
>  copy {wicket-velocity =>
> wicket-experimental/wicket-http2/wicket-http2-servlet4}/src/main/java/module-info.java
> (83%)
>  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> wicket-experimental/wicket-http2/wicket-http2-servlet4/src/test/java/org/apache/wicket/http2/markup/head/servlet4}/util/license/ApacheLicenceHeaderTest.java
> (95%)
>  delete mode 100644
> wicket-experimental/wicket-http2/wicket-http2-servlet4/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
>  copy {wicket-native-websocket/wicket-native-websocket-javax =>
> wicket-experimental/wicket-http2/wicket-http2-tomcat}/src/main/java/module-info.java
> (81%)
>  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> wicket-experimental/wicket-http2/wicket-http2-tomcat/src/test/java/org/apache/wicket/http2/markup/head/tomcat}/util/license/ApacheLicenceHeaderTest.java
> (95%)
>  delete mode 100644
> wicket-experimental/wicket-http2/wicket-http2-tomcat/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
>  copy {wicket-native-websocket/wicket-native-websocket-javax =>
> wicket-experimental/wicket-http2/wicket-http2-undertow}/src/main/java/module-info.java
> (81%)
>  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> wicket-experimental/wicket-http2/wicket-http2-undertow/src/test/java/org/apache/wicket/http2/markup/head/undertow}/util/license/ApacheLicenceHeaderTest.java
> (95%)
>  delete mode 100644
> wicket-experimental/wicket-http2/wicket-http2-undertow/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
>


-- 
Best regards,
Maxim

Re: [wicket] branch wicket-9.x-with-jpms updated (d0b8d69 -> a101808)

Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Jul 16, 2021 at 6:32 PM Maxim Solodovnik <so...@gmail.com>
wrote:

> Hello All,
>
> Maybe we can set-up `apache-rat-plugin` plugin to check the licence headers
> and drop all these ApacheLicenceHeaderTest.java?
>

I don't mind such change if it covers what our current tests do!


>
> On Fri, 16 Jul 2021 at 20:29, <mg...@apache.org> wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > mgrigorov pushed a change to branch wicket-9.x-with-jpms
> > in repository https://gitbox.apache.org/repos/asf/wicket.git.
> >
> >
> >     from d0b8d69  WICKET-6903 Replace maven-clirr-plugin with something
> > newer
> >      add a101808  WICKET-6904 Make Apache Wicket fully supporting Java9+
> > module system
> >
> > No new revisions were added by this update.
> >
> > Summary of changes:
> >  wicket-experimental/wicket-http2/pom.xml           | 11 +++++++
> >  .../src/main/java/module-info.java                 |  9 +++---
> >  .../util/license/ApacheLicenceHeaderTest.java      |  2 +-
> >  .../util/license/ApacheLicenceHeaderTest.java      | 34
> > ----------------------
> >  .../wicket-http2/wicket-http2-jetty/pom.xml        |  4 +++
> >  .../src/main/java/module-info.java                 | 11 ++++---
> >  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
> >  .../util/license/ApacheLicenceHeaderTest.java      | 34
> > ----------------------
> >  .../src/main/java/module-info.java                 | 10 +++----
> >  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
> >  .../util/license/ApacheLicenceHeaderTest.java      | 34
> > ----------------------
> >  .../wicket-http2/wicket-http2-tomcat/pom.xml       |  4 +++
> >  .../src/main/java/module-info.java                 | 11 ++++---
> >  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
> >  .../util/license/ApacheLicenceHeaderTest.java      | 34
> > ----------------------
> >  .../wicket-http2/wicket-http2-undertow/pom.xml     |  4 +++
> >  .../src/main/java/module-info.java                 | 11 ++++---
> >  .../util/license/ApacheLicenceHeaderTest.java      |  3 +-
> >  .../util/license/ApacheLicenceHeaderTest.java      | 34
> > ----------------------
> >  19 files changed, 53 insertions(+), 206 deletions(-)
> >  copy {wicket-velocity =>
> >
> wicket-experimental/wicket-http2/wicket-http2-core}/src/main/java/module-info.java
> > (85%)
> >  copy {wicket-extensions/src/test/java/org/apache/wicket/extensions =>
> >
> wicket-experimental/wicket-http2/wicket-http2-core/src/test/java/org/apache/wicket/http2/markup}/util/license/ApacheLicenceHeaderTest.java
> > (96%)
> >  delete mode 100644
> >
> wicket-experimental/wicket-http2/wicket-http2-core/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
> >  copy {wicket-native-websocket/wicket-native-websocket-javax =>
> >
> wicket-experimental/wicket-http2/wicket-http2-jetty}/src/main/java/module-info.java
> > (81%)
> >  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> >
> wicket-experimental/wicket-http2/wicket-http2-jetty/src/test/java/org/apache/wicket/http2/markup/head/jetty}/util/license/ApacheLicenceHeaderTest.java
> > (95%)
> >  delete mode 100644
> >
> wicket-experimental/wicket-http2/wicket-http2-jetty/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
> >  copy {wicket-velocity =>
> >
> wicket-experimental/wicket-http2/wicket-http2-servlet4}/src/main/java/module-info.java
> > (83%)
> >  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> >
> wicket-experimental/wicket-http2/wicket-http2-servlet4/src/test/java/org/apache/wicket/http2/markup/head/servlet4}/util/license/ApacheLicenceHeaderTest.java
> > (95%)
> >  delete mode 100644
> >
> wicket-experimental/wicket-http2/wicket-http2-servlet4/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
> >  copy {wicket-native-websocket/wicket-native-websocket-javax =>
> >
> wicket-experimental/wicket-http2/wicket-http2-tomcat}/src/main/java/module-info.java
> > (81%)
> >  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> >
> wicket-experimental/wicket-http2/wicket-http2-tomcat/src/test/java/org/apache/wicket/http2/markup/head/tomcat}/util/license/ApacheLicenceHeaderTest.java
> > (95%)
> >  delete mode 100644
> >
> wicket-experimental/wicket-http2/wicket-http2-tomcat/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
> >  copy {wicket-native-websocket/wicket-native-websocket-javax =>
> >
> wicket-experimental/wicket-http2/wicket-http2-undertow}/src/main/java/module-info.java
> > (81%)
> >  copy {wicket-guice/src/test/java/org/apache/wicket/guice =>
> >
> wicket-experimental/wicket-http2/wicket-http2-undertow/src/test/java/org/apache/wicket/http2/markup/head/undertow}/util/license/ApacheLicenceHeaderTest.java
> > (95%)
> >  delete mode 100644
> >
> wicket-experimental/wicket-http2/wicket-http2-undertow/src/test/java/org/apache/wicket/util/license/ApacheLicenceHeaderTest.java
> >
>
>
> --
> Best regards,
> Maxim
>