You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Philip Zeyliger (JIRA)" <ji...@apache.org> on 2010/06/17 23:49:26 UTC

[jira] Commented: (AVRO-582) java: add comment to generated code warning not to call set & get

    [ https://issues.apache.org/jira/browse/AVRO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879953#action_12879953 ] 

Philip Zeyliger commented on AVRO-582:
--------------------------------------

+1 to Javadoc, but do we have flexibility to rename them?  Java APIs are riddled with gets and sets, whereas this is more like readInternal, writeInternal or something.

> java: add comment to generated code warning not to call set & get
> -----------------------------------------------------------------
>
>                 Key: AVRO-582
>                 URL: https://issues.apache.org/jira/browse/AVRO-582
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.4.0
>
>
> Java's specific compiler generates classes with set(int, Object) and get(int) methods, used by the DatumReader and DatumWriter implementations to read and write instances.  These methods are not intended for users to call, but must be public.  We should add a comment to the generated code indicating this, to reduce confusion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.