[GitHub] [accumulo] milleruntime commented on a change in pull request #1945: Create readTablets method in Ample. Closes #1473

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1945:
URL: https://github.com/apache/accumulo/pull/1945#discussion_r581302314



##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
##########
@@ -85,15 +85,20 @@
     private boolean saveKeyValues;
     private TableId tableId;
     private ReadConsistency readConsistency = ReadConsistency.IMMEDIATE;
+    private AccumuloClient _client;
+
+    Builder(AccumuloClient client) {
+      this._client = client;
+    }
 
     @Override
-    public TabletsMetadata build(AccumuloClient client) {
-      Preconditions.checkState(level == null ^ table == null);
+    public TabletsMetadata build() {
+      Preconditions.checkState((level == null) != (table == null));

Review comment:
       I'm not sure what this is guarding against... only one can be null and only one set? I feel like this would be less confusing as two separate checks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org