You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2015/03/17 08:01:25 UTC
Review Request 32127: SAMZA-586
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32127/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
fix compression.type in kafka checkpoint manager. add test for kafka system factory.
add injected props for producer to disable compression
Diffs
-----
samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala f977b8bd1f20386175d0dd79a9844f1b5394f84c
samza-core/src/test/scala/org/apache/samza/config/TestStorageConfig.scala PRE-CREATION
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 7fc6d89b5d703a7c10a212aaa8d3f9231996b897
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala 4f15002325bc0154991f9a35312e903d15ef81e7
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala 5f65144146109418b4ec2ac40b3a69cb97f26224
Diff: https://reviews.apache.org/r/32127/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 32127: SAMZA-586
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32127/#review76803
-----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala
<https://reviews.apache.org/r/32127/#comment124460>
is it necessary to convert to Set ? Seq has the contain method.
- Yan Fang
On March 17, 2015, 7:01 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32127/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 7:01 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> fix compression.type in kafka checkpoint manager. add test for kafka system factory.
>
>
> add injected props for producer to disable compression
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala f977b8bd1f20386175d0dd79a9844f1b5394f84c
> samza-core/src/test/scala/org/apache/samza/config/TestStorageConfig.scala PRE-CREATION
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 7fc6d89b5d703a7c10a212aaa8d3f9231996b897
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala 4f15002325bc0154991f9a35312e903d15ef81e7
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala 5f65144146109418b4ec2ac40b3a69cb97f26224
>
> Diff: https://reviews.apache.org/r/32127/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 32127: SAMZA-586
Posted by Naveen Somasundaram <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32127/#review76818
-----------------------------------------------------------
Ship it!
Ship It!
- Naveen Somasundaram
On March 17, 2015, 7:01 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32127/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 7:01 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> fix compression.type in kafka checkpoint manager. add test for kafka system factory.
>
>
> add injected props for producer to disable compression
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala f977b8bd1f20386175d0dd79a9844f1b5394f84c
> samza-core/src/test/scala/org/apache/samza/config/TestStorageConfig.scala PRE-CREATION
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 7fc6d89b5d703a7c10a212aaa8d3f9231996b897
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala 4f15002325bc0154991f9a35312e903d15ef81e7
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala 5f65144146109418b4ec2ac40b3a69cb97f26224
>
> Diff: https://reviews.apache.org/r/32127/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 32127: SAMZA-586
Posted by Naveen Somasundaram <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32127/#review76817
-----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
<https://reviews.apache.org/r/32127/#comment124475>
https://issues.apache.org/jira/browse/SAMZA-393 seems to be something else ?
- Naveen Somasundaram
On March 17, 2015, 7:01 a.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32127/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 7:01 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> fix compression.type in kafka checkpoint manager. add test for kafka system factory.
>
>
> add injected props for producer to disable compression
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala f977b8bd1f20386175d0dd79a9844f1b5394f84c
> samza-core/src/test/scala/org/apache/samza/config/TestStorageConfig.scala PRE-CREATION
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 7fc6d89b5d703a7c10a212aaa8d3f9231996b897
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala 4f15002325bc0154991f9a35312e903d15ef81e7
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemFactory.scala 5f65144146109418b4ec2ac40b3a69cb97f26224
>
> Diff: https://reviews.apache.org/r/32127/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>