[GitHub] [hadoop] ayushtkn commented on a diff in pull request #4422: HADOOP-18284. Remove Unnecessary semicolon ';'

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #4422:
URL: https://github.com/apache/hadoop/pull/4422#discussion_r899824845


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFileSeqFileComparison.java:
##########
@@ -516,7 +516,7 @@ private static String parameters2String(MyOptions options) {
   }
 
   private static class MyOptions {
-    String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();;
+    private String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();;

Review Comment:
   no need to add `private` here as part of this change



##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/MapTask.java:
##########
@@ -930,7 +930,7 @@ private long getOutputBytes(List<Statistics> stats) {
     // spill accounting
     private int maxRec;
     private int softLimit;
-    boolean spillInProgress;;
+    private boolean spillInProgress;

Review Comment:
   no need to add `private` here as part of this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org