You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2023/06/01 02:49:56 UTC
[GitHub] [doris] amorynan opened a new pull request, #20294: [Feature](array-functions)improve array functions for array_last_index
amorynan opened a new pull request, #20294:
URL: https://github.com/apache/doris/pull/20294
## Proposed changes
Now we just support array_first_index for lambda input , but no array_last_index
Issue Number: close #xxx
<--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #20294:
URL: https://github.com/apache/doris/pull/20294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #20294:
URL: https://github.com/apache/doris/pull/20294#discussion_r1212512384
##########
be/src/vec/functions/array/function_array_lambda_index.cpp:
##########
@@ -45,11 +45,12 @@ class FunctionContext;
namespace doris::vectorized {
// array_first_index([0, 1, 0]) -> [2]
Review Comment:
add `array_last_index` annotation like `array_first_index`
##########
be/src/vec/functions/array/function_array_lambda_index.cpp:
##########
@@ -45,11 +45,12 @@ class FunctionContext;
namespace doris::vectorized {
// array_first_index([0, 1, 0]) -> [2]
-class FunctionArrayFirstIndex : public IFunction {
+template <bool first>
+class FunctionArrayLambdaIndex : public IFunction {
public:
Review Comment:
if this class is just for `array_first_index` `array_last_index`, so i think this class could be renamed to `FunctionArrayFirstOrLastIndex` is better? Or we need some enum
##########
be/src/vec/functions/array/function_array_lambda_index.cpp:
##########
@@ -88,10 +89,21 @@ class FunctionArrayFirstIndex : public IFunction {
// default index is 0 if such index is not found
size_t first_index = 0;
Review Comment:
rename first_index -> dst_index
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571430406
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571248647
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571430269
rum p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571272490
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1573092561
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571527204
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571280173
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] amorynan commented on pull request #20294: [Feature](array-functions)improve array functions for array_last_index
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #20294:
URL: https://github.com/apache/doris/pull/20294#issuecomment-1571281016
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org