You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 13:58:16 UTC
[GitHub] [airflow] shizidushu opened a new pull request #13153: fix stout decoding issue and add option to run command as powershell script
shizidushu opened a new pull request #13153:
URL: https://github.com/apache/airflow/pull/13153
Fix https://github.com/apache/airflow/issues/13132 and add the ability to run command as powershell script.
Sorry. I didn't know how to write unit test for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13153: fix stout decoding issue and add option to run command as powershell script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13153:
URL: https://github.com/apache/airflow/pull/13153#issuecomment-787209745
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13153: fix stout decoding issue and add option to run command as powershell script
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13153:
URL: https://github.com/apache/airflow/pull/13153#issuecomment-748097992
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13153: WinRM Operator: Fix stout decoding issue & add option to run command
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13153:
URL: https://github.com/apache/airflow/pull/13153#issuecomment-787522719
Updated PR with fixes to static checks and rebased to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13153: fix stout decoding issue and add option to run command as powershell script
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13153:
URL: https://github.com/apache/airflow/pull/13153#discussion_r584359471
##########
File path: airflow/providers/microsoft/winrm/operators/winrm.py
##########
@@ -88,10 +97,17 @@ def execute(self, context: dict) -> Union[list, str]:
# pylint: disable=too-many-nested-blocks
try:
- self.log.info("Running command: '%s'...", self.command)
- command_id = self.winrm_hook.winrm_protocol.run_command( # type: ignore[attr-defined]
- winrm_client, self.command
- )
+ if self.ps_path is not None:
+ self.log.info("Running command as powershell script: '%s'...", self.command)
+ encoded_ps = b64encode(self.command.encode('utf_16_le')).decode('ascii')
+ command_id = self.winrm_hook.winrm_protocol.run_command( # type: ignore[attr-defined]
+ winrm_client, '{0} -encodedcommand {1}'.format(self.ps_path, encoded_ps)
Review comment:
```suggestion
winrm_client, f'{self.ps_path} -encodedcommand {encoded_ps}'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13153: WinRM Operator: Fix stout decoding issue & add option to run command
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13153:
URL: https://github.com/apache/airflow/pull/13153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13153: WinRM Operator: Fix stout decoding issue & add option to run command
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13153:
URL: https://github.com/apache/airflow/pull/13153#issuecomment-787970668
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13153: fix stout decoding issue and add option to run command as powershell script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13153:
URL: https://github.com/apache/airflow/pull/13153#issuecomment-787521932
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org