You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2022/07/12 02:33:28 UTC
[kudu-CR] KUDU-2671 Remove commas from multi-level custom hash schema printing
Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18720
Change subject: KUDU-2671 Remove commas from multi-level custom hash schema printing
......................................................................
KUDU-2671 Remove commas from multi-level custom hash schema printing
Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/18720/1
--
To view, visit http://gerrit.cloudera.org:8080/18720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
Gerrit-Change-Number: 18720
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
[kudu-CR] KUDU-2671 Remove commas from multi-level custom hash schema printing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Kurt Deschler. ( http://gerrit.cloudera.org:8080/18720 )
Change subject: KUDU-2671 Remove commas from multi-level custom hash schema printing
......................................................................
KUDU-2671 Remove commas from multi-level custom hash schema printing
This patch removes commas separating hash dimensions in the formatted
output of a range-specific hash schema. An extra test scenario is
added to spot regressions in the formatted output and cover the
functionality of creating and altering tables with multi-dimensional
hash schemas.
Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
2 files changed, 234 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/18720/2
--
To view, visit http://gerrit.cloudera.org:8080/18720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
Gerrit-Change-Number: 18720
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2671 Remove commas from multi-level custom hash schema printing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18720 )
Change subject: KUDU-2671 Remove commas from multi-level custom hash schema printing
......................................................................
KUDU-2671 Remove commas from multi-level custom hash schema printing
This patch removes commas separating hash dimensions in the formatted
output of a range-specific hash schema. An extra test scenario is
added to spot regressions in the formatted output and cover the
functionality of creating and altering tables with multi-dimensional
hash schemas.
Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
Reviewed-on: http://gerrit.cloudera.org:8080/18720
Tested-by: Kudu Jenkins
Reviewed-by: Kurt Deschler <kd...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
2 files changed, 234 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Kurt Deschler: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
Gerrit-Change-Number: 18720
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 Remove commas from multi-level custom hash schema printing
Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18720 )
Change subject: KUDU-2671 Remove commas from multi-level custom hash schema printing
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
Gerrit-Change-Number: 18720
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 02:04:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 Remove commas from multi-level custom hash schema printing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18720 )
Change subject: KUDU-2671 Remove commas from multi-level custom hash schema printing
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I424790b62fb4a323f59d4d33901faae57cf39ad0
Gerrit-Change-Number: 18720
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 05:48:51 +0000
Gerrit-HasComments: No