You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/01/25 19:06:28 UTC

svn commit: r1780256 - /jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java

Author: pmouawad
Date: Wed Jan 25 19:06:28 2017
New Revision: 1780256

URL: http://svn.apache.org/viewvc?rev=1780256&view=rev
Log:
Bug 55652 - JavaSampler silently resets classname if class can not be found
Felix notes
Bugzilla Id: 55652

Modified:
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java

Modified: jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java?rev=1780256&r1=1780255&r2=1780256&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java (original)
+++ jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java Wed Jan 25 19:06:28 2017
@@ -247,11 +247,7 @@ public class JavaConfigGui extends Abstr
             classNameLabeledChoice.addValue(className);
         }
         
-        if(!classOk(className)) {
-            warningLabel.setVisible(true);
-        } else {
-            warningLabel.setVisible(false);
-        }
+        warningLabel.setVisible(!classOk(className));
         classNameLabeledChoice.setText(className);
     }
 
@@ -264,6 +260,7 @@ public class JavaConfigGui extends Abstr
         try {
             JavaSamplerClient client = (JavaSamplerClient) Class.forName(className, true,
                     Thread.currentThread().getContextClassLoader()).newInstance();
+            // Just to use client
             return client != null;
         } catch (Exception ex) {
             log.error("Error creating class:'"+className+"' in JavaSampler "+getName()