You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/31 17:25:17 UTC
[GitHub] [incubator-mxnet] reminisce commented on a change in pull request
#15090: Enable serializing/deserializing ndarrays in np_shape semantics
reminisce commented on a change in pull request #15090: Enable serializing/deserializing ndarrays in np_shape semantics
URL: https://github.com/apache/incubator-mxnet/pull/15090#discussion_r289481366
##########
File path: src/ndarray/ndarray.cc
##########
@@ -1580,13 +1581,20 @@ static const uint32_t NDARRAY_V1_MAGIC = 0xF993fac8;
/* magic number for ndarray version 2, with storage type */
static const uint32_t NDARRAY_V2_MAGIC = 0xF993fac9;
+// magic number for ndarray version 3, with np shape semantics.
+// The ndarray must be saved and loaded within np shape semantics.
+static const uint32_t NDARRAY_V3_MAGIC = 0xF993faca;
Review comment:
Yes. It's here.
https://github.com/apache/incubator-mxnet/pull/15090/files#diff-69757562d07268150de8b369ff5b6b61R1725
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services