You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/04 22:23:34 UTC

Review Request 58191: Renamed a test helper for clarity.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58191/
-----------------------------------------------------------

Review request for mesos, Gast�n Kleiman and Vinod Kone.


Repository: mesos


Description
-------

`HealthCheckTestHelper` is actually a simple libprocess-based HTTP
server. To make it clear and enable it usage in non health check
related tests, rename it to `HttpServerTestHelper`.


Diffs
-----

  src/Makefile.am 071656ad7354a802e8292140a7181cb70b68fe9e 
  src/tests/CMakeLists.txt 8e368a8c8f83293529e00f9902174bff8e798d51 
  src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 
  src/tests/health_check_test_helper.hpp cdedf09ebaeb976d33090fe708b0ce5c118a6682 
  src/tests/health_check_test_helper.cpp 88352c1bfe5d484ec2ba602b4f9a8139c868fef7 
  src/tests/health_check_tests.cpp 211f8b8578e811d3f2a229387cc0ce8327ae8cb6 
  src/tests/test_helper_main.cpp 5d99ede44f958b36d33dede02f2ab7a5854a01f3 


Diff: https://reviews.apache.org/r/58191/diff/1/


Testing
-------

See https://reviews.apache.org/r/58196/


Thanks,

Alexander Rukletsov

Re: Review Request 58191: Renamed a test helper for clarity.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58191/
-----------------------------------------------------------

(Updated April 19, 2017, 3:15 p.m.)


Review request for mesos, Gast�n Kleiman and Vinod Kone.


Changes
-------

Rebased. NNTR.


Repository: mesos


Description
-------

`HealthCheckTestHelper` is actually a simple libprocess-based HTTP
server. To make it clear and enable it usage in non health check
related tests, rename it to `HttpServerTestHelper`.


Diffs (updated)
-----

  src/Makefile.am 1fc453c497f278c9fc3fa5e91eb720a932915fde 
  src/tests/CMakeLists.txt 8e368a8c8f83293529e00f9902174bff8e798d51 
  src/tests/check_tests.cpp 79ba5eb38b6e7338392fb17ad39f6cd250f87d88 
  src/tests/health_check_test_helper.hpp cdedf09ebaeb976d33090fe708b0ce5c118a6682 
  src/tests/health_check_test_helper.cpp 88352c1bfe5d484ec2ba602b4f9a8139c868fef7 
  src/tests/health_check_tests.cpp 3bba1bb28ce8bde8abc14e3303264d6fdea64286 
  src/tests/test_helper_main.cpp 5d99ede44f958b36d33dede02f2ab7a5854a01f3 


Diff: https://reviews.apache.org/r/58191/diff/2/

Changes: https://reviews.apache.org/r/58191/diff/1-2/


Testing
-------

See https://reviews.apache.org/r/58196/


Thanks,

Alexander Rukletsov

Re: Review Request 58191: Renamed a test helper for clarity.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58191/#review171295
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 4, 2017, 10:23 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58191/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:23 p.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `HealthCheckTestHelper` is actually a simple libprocess-based HTTP
> server. To make it clear and enable it usage in non health check
> related tests, rename it to `HttpServerTestHelper`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 071656ad7354a802e8292140a7181cb70b68fe9e 
>   src/tests/CMakeLists.txt 8e368a8c8f83293529e00f9902174bff8e798d51 
>   src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 
>   src/tests/health_check_test_helper.hpp cdedf09ebaeb976d33090fe708b0ce5c118a6682 
>   src/tests/health_check_test_helper.cpp 88352c1bfe5d484ec2ba602b4f9a8139c868fef7 
>   src/tests/health_check_tests.cpp 211f8b8578e811d3f2a229387cc0ce8327ae8cb6 
>   src/tests/test_helper_main.cpp 5d99ede44f958b36d33dede02f2ab7a5854a01f3 
> 
> 
> Diff: https://reviews.apache.org/r/58191/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58196/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>