You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/28 12:24:09 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #887: ORC-976: Optimize compute zigzagliterals
guiyanakuang opened a new pull request #887:
URL: https://github.com/apache/orc/pull/887
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
```java
private void computeZigZagLiterals() {
// populate zigzag encoded literals
long zzEncVal = 0;
for (int i = 0; i < numLiterals; i++) {
if (signed) {
zzEncVal = utils.zigzagEncode(literals[i]);
} else {
zzEncVal = literals[i];
}
zigzagLiterals[i] = zzEncVal;
}
}
```
Avoid conditional judgments in loops.
The unsigned case can use literals instead of zigzagLiterals.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
optimize write performance.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on a change in pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on a change in pull request #887:
URL: https://github.com/apache/orc/pull/887#discussion_r697949572
##########
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##########
@@ -545,14 +547,10 @@ private void determineEncoding() {
private void computeZigZagLiterals() {
// populate zigzag encoded literals
- long zzEncVal = 0;
- for (int i = 0; i < numLiterals; i++) {
- if (signed) {
- zzEncVal = utils.zigzagEncode(literals[i]);
- } else {
- zzEncVal = literals[i];
+ if (signed) {
Review comment:
I quite agree. fix in 7de084b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907723209
> Thank you, @guiyanakuang . In this case, we had batter improve C++ code together for consistency. Could you update it in this PR?
>
> https://github.com/apache/orc/blob/main/c++/src/RleEncoderV2.cc#L170-L180
>
> cc @wgtmac
I think I can, although I don't use c++ much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907724332
Thank you for updating and considering C++ change together, @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907971335
Thank you, @guiyanakuang and @wgtmac !
Merged to main/1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907728267
Update C++ improve, please help review code. I don't use C++ much. @dongjoon-hyun @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #887:
URL: https://github.com/apache/orc/pull/887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907820794
Also, cc @omalley , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #887:
URL: https://github.com/apache/orc/pull/887#discussion_r697948360
##########
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##########
@@ -545,14 +547,10 @@ private void determineEncoding() {
private void computeZigZagLiterals() {
// populate zigzag encoded literals
- long zzEncVal = 0;
- for (int i = 0; i < numLiterals; i++) {
- if (signed) {
- zzEncVal = utils.zigzagEncode(literals[i]);
- } else {
- zzEncVal = literals[i];
+ if (signed) {
Review comment:
Shall we remove `if` statement and add an assertion at the first line of this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #887: ORC-976: Optimize compute zigzagliterals
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907722040
cc @pgaref and @williamhyun , too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org