You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/28 07:04:47 UTC
[GitHub] [pinot] saurabhd336 opened a new pull request, #8606: Add unrecognizedProperties to schema and tableConfigs APIs
saurabhd336 opened a new pull request, #8606:
URL: https://github.com/apache/pinot/pull/8606
This PR is a follow up of https://github.com/apache/pinot/pull/8514. It adds the "unrecognizedProperties" fields to /schemas and /tableConfigs APIs
GH issue: https://github.com/apache/pinot/issues/8318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
saurabhd336 commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r861467331
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -243,13 +276,26 @@ public String validateSchema(FormDataMultiPart multiPart) {
@ApiOperation(value = "Validate schema", notes = "This API returns the schema that matches the one you get "
+ "from 'GET /schema/{schemaName}'. This allows us to validate schema before apply.")
@ApiResponses(value = {
- @ApiResponse(code = 200, message = "Successfully validated schema"),
- @ApiResponse(code = 400, message = "Missing or invalid request body"),
- @ApiResponse(code = 500, message = "Internal error")
+ @ApiResponse(code = 200, message = "Successfully validated schema"), @ApiResponse(code = 400, message =
+ "Missing or invalid request body"), @ApiResponse(code = 500, message = "Internal error")
})
- public String validateSchema(Schema schema) {
+ public String validateSchema(String schemaJsonString) {
+ Pair<Schema, Map<String, Object>> schemaAndUnrecognizedProps = null;
+ try {
+ schemaAndUnrecognizedProps = JsonUtils.stringToObjectAndUnrecognizedProperties(schemaJsonString, Schema.class);
+ } catch (Exception e) {
+ String msg = String.format("Invalid schema config json string: %s", schemaJsonString);
+ throw new ControllerApplicationException(LOGGER, msg, Response.Status.BAD_REQUEST, e);
+ }
+ Schema schema = schemaAndUnrecognizedProps.getLeft();
validateSchemaInternal(schema);
- return schema.toPrettyJsonString();
+ ObjectNode response = schema.toJsonObject();
+ response.set("unrecognizedProperties", JsonUtils.objectToJsonNode(schemaAndUnrecognizedProps.getRight()));
+ try {
+ return JsonUtils.objectToPrettyString(response);
Review Comment:
There's some formatting difference that way. This API used to return beautified json string. Trying to keep it same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] npawar commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
npawar commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r862250198
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/StringUtil.java:
##########
@@ -53,4 +57,22 @@ public static String sanitizeStringValue(String value, int maxLength) {
}
return value.substring(0, Math.min(index, maxLength));
}
+
+ /**
+ * InputStream object to String
+ * @param inputStream InputStream to be converted
+ * @return String holding the contents of the inputStream
+ * @throws IOException
+ */
+ public static String inputStreamToString(InputStream inputStream)
Review Comment:
curious why you chose to add this vs using the short IOUtils.toString(InputStream, CharSet) method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
saurabhd336 commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r861469485
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -145,16 +148,19 @@ public SuccessResponse deleteSchema(
@Authenticate(AccessType.UPDATE)
@ApiOperation(value = "Update a schema", notes = "Updates a schema")
@ApiResponses(value = {
- @ApiResponse(code = 200, message = "Successfully updated schema"),
- @ApiResponse(code = 404, message = "Schema not found"),
- @ApiResponse(code = 400, message = "Missing or invalid request body"),
- @ApiResponse(code = 500, message = "Internal error")
+ @ApiResponse(code = 200, message = "Successfully updated schema"), @ApiResponse(code = 404, message = "Schema "
Review Comment:
Ack.
Even with latest codestyle.xml, intellij seems to be doing this when I auto format the file. Have fixed these. Will look into the codestyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
saurabhd336 commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r861469694
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java:
##########
@@ -147,16 +150,18 @@ public String getConfig(
@POST
@Produces(MediaType.APPLICATION_JSON)
@Path("/tableConfigs")
- @ApiOperation(value = "Add the TableConfigs using the tableConfigsStr json",
- notes = "Add the TableConfigs using the tableConfigsStr json")
- public SuccessResponse addConfig(
- String tableConfigsStr,
+ @ApiOperation(value = "Add the TableConfigs using the tableConfigsStr json", notes = "Add the TableConfigs using "
Review Comment:
ACK. Intellij auto format is messing it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
saurabhd336 commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r861467331
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -243,13 +276,26 @@ public String validateSchema(FormDataMultiPart multiPart) {
@ApiOperation(value = "Validate schema", notes = "This API returns the schema that matches the one you get "
+ "from 'GET /schema/{schemaName}'. This allows us to validate schema before apply.")
@ApiResponses(value = {
- @ApiResponse(code = 200, message = "Successfully validated schema"),
- @ApiResponse(code = 400, message = "Missing or invalid request body"),
- @ApiResponse(code = 500, message = "Internal error")
+ @ApiResponse(code = 200, message = "Successfully validated schema"), @ApiResponse(code = 400, message =
+ "Missing or invalid request body"), @ApiResponse(code = 500, message = "Internal error")
})
- public String validateSchema(Schema schema) {
+ public String validateSchema(String schemaJsonString) {
+ Pair<Schema, Map<String, Object>> schemaAndUnrecognizedProps = null;
+ try {
+ schemaAndUnrecognizedProps = JsonUtils.stringToObjectAndUnrecognizedProperties(schemaJsonString, Schema.class);
+ } catch (Exception e) {
+ String msg = String.format("Invalid schema config json string: %s", schemaJsonString);
+ throw new ControllerApplicationException(LOGGER, msg, Response.Status.BAD_REQUEST, e);
+ }
+ Schema schema = schemaAndUnrecognizedProps.getLeft();
validateSchemaInternal(schema);
- return schema.toPrettyJsonString();
+ ObjectNode response = schema.toJsonObject();
+ response.set("unrecognizedProperties", JsonUtils.objectToJsonNode(schemaAndUnrecognizedProps.getRight()));
+ try {
+ return JsonUtils.objectToPrettyString(response);
Review Comment:
There's some formatting difference that way. This API used to return beautified json string. Keeping it same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #8606:
URL: https://github.com/apache/pinot/pull/8606#issuecomment-1111895438
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8606?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8606](https://codecov.io/gh/apache/pinot/pull/8606?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aac0db0) into [master](https://codecov.io/gh/apache/pinot/commit/232b946419d05b785610e9b2daf7467f5f8bee82?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (232b946) will **decrease** coverage by `3.75%`.
> The diff coverage is `25.00%`.
```diff
@@ Coverage Diff @@
## master #8606 +/- ##
============================================
- Coverage 70.68% 66.92% -3.76%
+ Complexity 4321 4238 -83
============================================
Files 1693 1281 -412
Lines 88795 64588 -24207
Branches 13472 10130 -3342
============================================
- Hits 62767 43228 -19539
+ Misses 21639 18250 -3389
+ Partials 4389 3110 -1279
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `66.92% <25.00%> (-0.03%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/main/java/org/apache/pinot/spi/data/Schema.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9TY2hlbWEuamF2YQ==) | `73.62% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/java/org/apache/pinot/spi/utils/StringUtil.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvU3RyaW5nVXRpbC5qYXZh) | `45.45% <0.00%> (-54.55%)` | :arrow_down: |
| [...ain/java/org/apache/pinot/spi/utils/JsonUtils.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvSnNvblV0aWxzLmphdmE=) | `66.40% <60.00%> (-0.67%)` | :arrow_down: |
| [...va/org/apache/pinot/core/routing/RoutingTable.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yb3V0aW5nL1JvdXRpbmdUYWJsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/common/config/NettyConfig.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL05ldHR5Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/common/metrics/MinionMeter.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...apache/pinot/common/helix/ExtraInstanceConfig.java](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaGVsaXgvRXh0cmFJbnN0YW5jZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [637 more](https://codecov.io/gh/apache/pinot/pull/8606/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8606?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8606?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [232b946...aac0db0](https://codecov.io/gh/apache/pinot/pull/8606?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r861406857
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -145,16 +148,19 @@ public SuccessResponse deleteSchema(
@Authenticate(AccessType.UPDATE)
@ApiOperation(value = "Update a schema", notes = "Updates a schema")
@ApiResponses(value = {
- @ApiResponse(code = 200, message = "Successfully updated schema"),
- @ApiResponse(code = 404, message = "Schema not found"),
- @ApiResponse(code = 400, message = "Missing or invalid request body"),
- @ApiResponse(code = 500, message = "Internal error")
+ @ApiResponse(code = 200, message = "Successfully updated schema"), @ApiResponse(code = 404, message = "Schema "
Review Comment:
Don't change this format (if you apply the latest checkstyle rules, it should not reformat this)
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -243,13 +276,26 @@ public String validateSchema(FormDataMultiPart multiPart) {
@ApiOperation(value = "Validate schema", notes = "This API returns the schema that matches the one you get "
+ "from 'GET /schema/{schemaName}'. This allows us to validate schema before apply.")
@ApiResponses(value = {
- @ApiResponse(code = 200, message = "Successfully validated schema"),
- @ApiResponse(code = 400, message = "Missing or invalid request body"),
- @ApiResponse(code = 500, message = "Internal error")
+ @ApiResponse(code = 200, message = "Successfully validated schema"), @ApiResponse(code = 400, message =
+ "Missing or invalid request body"), @ApiResponse(code = 500, message = "Internal error")
})
- public String validateSchema(Schema schema) {
+ public String validateSchema(String schemaJsonString) {
+ Pair<Schema, Map<String, Object>> schemaAndUnrecognizedProps = null;
+ try {
+ schemaAndUnrecognizedProps = JsonUtils.stringToObjectAndUnrecognizedProperties(schemaJsonString, Schema.class);
+ } catch (Exception e) {
+ String msg = String.format("Invalid schema config json string: %s", schemaJsonString);
+ throw new ControllerApplicationException(LOGGER, msg, Response.Status.BAD_REQUEST, e);
+ }
+ Schema schema = schemaAndUnrecognizedProps.getLeft();
validateSchemaInternal(schema);
- return schema.toPrettyJsonString();
+ ObjectNode response = schema.toJsonObject();
+ response.set("unrecognizedProperties", JsonUtils.objectToJsonNode(schemaAndUnrecognizedProps.getRight()));
+ try {
+ return JsonUtils.objectToPrettyString(response);
Review Comment:
(minor) I think you can directly return the `ObjectNode`
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java:
##########
@@ -147,16 +150,18 @@ public String getConfig(
@POST
@Produces(MediaType.APPLICATION_JSON)
@Path("/tableConfigs")
- @ApiOperation(value = "Add the TableConfigs using the tableConfigsStr json",
- notes = "Add the TableConfigs using the tableConfigsStr json")
- public SuccessResponse addConfig(
- String tableConfigsStr,
+ @ApiOperation(value = "Add the TableConfigs using the tableConfigsStr json", notes = "Add the TableConfigs using "
Review Comment:
(code style) Same here, don't change this format because it doesn't improve readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
saurabhd336 commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r862453111
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/StringUtil.java:
##########
@@ -53,4 +57,22 @@ public static String sanitizeStringValue(String value, int maxLength) {
}
return value.substring(0, Math.min(index, maxLength));
}
+
+ /**
+ * InputStream object to String
+ * @param inputStream InputStream to be converted
+ * @return String holding the contents of the inputStream
+ * @throws IOException
+ */
+ public static String inputStreamToString(InputStream inputStream)
Review Comment:
Just wasn't aware commons dependency is already added to the module.
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] npawar merged pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs
Posted by GitBox <gi...@apache.org>.
npawar merged PR #8606:
URL: https://github.com/apache/pinot/pull/8606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org