You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/18 13:08:55 UTC

[GitHub] [doris] airborne12 opened a new pull request, #16078: [Fix](inverted index) fix add nulls bug for inverted fulltext index

airborne12 opened a new pull request, #16078:
URL: https://github.com/apache/doris/pull/16078

   # Proposed changes
   
   fix a bug for inverted index writer add_nulls function
   
   ## Problem summary
   
   We found a problem with inverted index when parser=english, if there were nulls in columns when flushing inverted index for them, it can cause CLucene throwing an exception.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #16078: [Fix](inverted index) fix add nulls bug for inverted fulltext index

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16078:
URL: https://github.com/apache/doris/pull/16078#issuecomment-1387052701

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #16078: [Fix](inverted index) fix add nulls bug for inverted fulltext index

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #16078:
URL: https://github.com/apache/doris/pull/16078#issuecomment-1387674906

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 36.04 seconds
    load time: 496 seconds
    storage size: 17122602771 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230118194501_clickbench_pr_83570.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #16078: [Fix](inverted index) fix add nulls bug for inverted fulltext index

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16078:
URL: https://github.com/apache/doris/pull/16078#issuecomment-1387096168

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #16078: [Fix](inverted index) fix add nulls bug for inverted fulltext index

Posted by GitBox <gi...@apache.org>.
morningman merged PR #16078:
URL: https://github.com/apache/doris/pull/16078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org