Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on code in PR #15939:
URL: https://github.com/apache/druid/pull/15939#discussion_r1512464432


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -15336,4 +15336,36 @@ public void testFilterParseLongNullable()
         ImmutableList.of(new Object[]{NullHandling.sqlCompatible() ? 4L : 0L})
     );
   }
+
+  @Test
+  public void testLatestByAggregatorOnSecondaryTimestamp()

Review Comment:
   this test passes even without the changes in this PR, am i missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org