You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/14 03:56:22 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
HyukjinKwon opened a new pull request #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573
### What changes were proposed in this pull request?
This PR address the comment at https://github.com/apache/spark/pull/26496#discussion_r379194091 and improves the migration guide to explicitly note that the legacy environment variable to set in both executor and driver.
### Why are the changes needed?
To clarify this env should be set both in driver and executors.
### Does this PR introduce any user-facing change?
Nope.
### How was this patch tested?
I checked it via md editor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586087183
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586089342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586454888
Thanks @HyukjinKwon and @zsxwing , good point to add. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586087187
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23149/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586089260
**[Test build #118392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118392/testReport)** for PR 27573 at commit [`a500e48`](https://github.com/apache/spark/commit/a500e48d05c794e3cae587e5d95902582d42bdfe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586086671
**[Test build #118392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118392/testReport)** for PR 27573 at commit [`a500e48`](https://github.com/apache/spark/commit/a500e48d05c794e3cae587e5d95902582d42bdfe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586086671
**[Test build #118392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118392/testReport)** for PR 27573 at commit [`a500e48`](https://github.com/apache/spark/commit/a500e48d05c794e3cae587e5d95902582d42bdfe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586089342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586089347
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118392/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586087183
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586086252
cc @zsxwing @BryanCutler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586089347
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118392/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27573:
[SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment
variable to set in both executor and driver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27573: [SPARK-29748][DOCS][FOLLOW-UP] Add a note that the legacy environment variable to set in both executor and driver
URL: https://github.com/apache/spark/pull/27573#issuecomment-586087187
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23149/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org