You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/31 01:06:49 UTC
Review Request 43024: Avoid unnecessary string copies in `json` for
protobuf messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43024/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-4566
https://issues.apache.org/jira/browse/MESOS-4566
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 6d7d033884cc6ed451e25bfc4638ac9186bbbcf5
Diff: https://reviews.apache.org/r/43024/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 43024: Avoid unnecessary string copies in `json`
for protobuf messages.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43024/#review117159
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 31, 2016, 12:06 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43024/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 12:06 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-4566
> https://issues.apache.org/jira/browse/MESOS-4566
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 6d7d033884cc6ed451e25bfc4638ac9186bbbcf5
>
> Diff: https://reviews.apache.org/r/43024/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 43024: Avoid unnecessary string copies in `json`
for protobuf messages.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43024/#review117135
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43023, 43024]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 31, 2016, 12:06 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43024/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 12:06 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-4566
> https://issues.apache.org/jira/browse/MESOS-4566
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 6d7d033884cc6ed451e25bfc4638ac9186bbbcf5
>
> Diff: https://reviews.apache.org/r/43024/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>