You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/02/26 20:12:55 UTC
Review Request 44097: SQOOP-2853: Sqoop2: Refactor TableDisplayer to
be used in document generation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44097/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2853
https://issues.apache.org/jira/browse/SQOOP-2853
Repository: sqoop-sqoop2
Description
-------
I would like to refactor the existing {{[TableDisplayer|https://github.com/apache/sqoop/blob/sqoop2/shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java]}}, so that it can generate tables for documentation as well. Right now that class is too tight with the way shell works.
Diffs
-----
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d973499
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ebbfe82
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 25bd1db
shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java a450aaf
shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java 2cf6972
shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java 6b61921
shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 8989913
shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java 51030d0
shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 49affa3
Diff: https://reviews.apache.org/r/44097/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 44097: SQOOP-2853: Sqoop2: Refactor TableDisplayer
to be used in document generation
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44097/#review122328
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Fine
On March 5, 2016, 4:52 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44097/
> -----------------------------------------------------------
>
> (Updated March 5, 2016, 4:52 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2853
> https://issues.apache.org/jira/browse/SQOOP-2853
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I would like to refactor the existing {{[TableDisplayer|https://github.com/apache/sqoop/blob/sqoop2/shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java]}}, so that it can generate tables for documentation as well. Right now that class is too tight with the way shell works.
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d973499
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ebbfe82
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 25bd1db
> shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java a450aaf
> shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java 2cf6972
> shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java 6b61921
> shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 8989913
> shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java 51030d0
>
> Diff: https://reviews.apache.org/r/44097/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 44097: SQOOP-2853: Sqoop2: Refactor TableDisplayer
to be used in document generation
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44097/
-----------------------------------------------------------
(Updated March 5, 2016, 4:52 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2853
https://issues.apache.org/jira/browse/SQOOP-2853
Repository: sqoop-sqoop2
Description
-------
I would like to refactor the existing {{[TableDisplayer|https://github.com/apache/sqoop/blob/sqoop2/shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java]}}, so that it can generate tables for documentation as well. Right now that class is too tight with the way shell works.
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d973499
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ebbfe82
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 25bd1db
shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java a450aaf
shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java 2cf6972
shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java 6b61921
shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 8989913
shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java 51030d0
Diff: https://reviews.apache.org/r/44097/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 44097: SQOOP-2853: Sqoop2: Refactor TableDisplayer
to be used in document generation
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44097/
-----------------------------------------------------------
(Updated March 4, 2016, 10:45 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2853
https://issues.apache.org/jira/browse/SQOOP-2853
Repository: sqoop-sqoop2
Description
-------
I would like to refactor the existing {{[TableDisplayer|https://github.com/apache/sqoop/blob/sqoop2/shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java]}}, so that it can generate tables for documentation as well. Right now that class is too tight with the way shell works.
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d973499
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ebbfe82
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 25bd1db
shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java a450aaf
shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java 2cf6972
shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java 6b61921
shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 8989913
shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java 51030d0
Diff: https://reviews.apache.org/r/44097/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 44097: SQOOP-2853: Sqoop2: Refactor TableDisplayer
to be used in document generation
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44097/#review121520
-----------------------------------------------------------
shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java (line 31)
<https://reviews.apache.org/r/44097/#comment183230>
nit: change the comment to something else, calling these Styles could be confusing given the Style type
shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java (line 170)
<https://reviews.apache.org/r/44097/#comment183232>
remove?
- Abraham Fine
On Feb. 26, 2016, 7:12 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44097/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:12 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2853
> https://issues.apache.org/jira/browse/SQOOP-2853
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I would like to refactor the existing {{[TableDisplayer|https://github.com/apache/sqoop/blob/sqoop2/shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java]}}, so that it can generate tables for documentation as well. Right now that class is too tight with the way shell works.
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java d973499
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ebbfe82
> shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 25bd1db
> shell/src/main/java/org/apache/sqoop/shell/ShowPrincipalFunction.java a450aaf
> shell/src/main/java/org/apache/sqoop/shell/ShowPrivilegeFunction.java 2cf6972
> shell/src/main/java/org/apache/sqoop/shell/ShowRoleFunction.java 6b61921
> shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java 8989913
> shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java 51030d0
> shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 49affa3
>
> Diff: https://reviews.apache.org/r/44097/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>