You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by vh...@apache.org on 2007/02/27 15:50:56 UTC
svn commit: r512266 -
/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
Author: vhennebert
Date: Tue Feb 27 06:50:52 2007
New Revision: 512266
URL: http://svn.apache.org/viewvc?view=rev&rev=512266
Log:
Add log messages to help understand the code
Modified:
xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java?view=diff&rev=512266&r1=512265&r2=512266
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java Tue Feb 27 06:50:52 2007
@@ -192,7 +192,7 @@
for (int i = activeRow + 1; i < rowGroup.length; i++) {
maxW += rowGroup[i].getHeight().opt;
}
- //log.debug("maxRemainingHeight=" + maxW);
+ log.debug("maxRemainingHeight=" + maxW);
return maxW;
}
@@ -238,6 +238,7 @@
borderBefore[column] = pgu.getBorders().getBorderBeforeWidth(false);
} else {
borderBefore[column] = pgu.getBorders().getBorderBeforeWidth(false) / 2;
+ log.trace("border before for column " + column + ": " + borderBefore[column]);
}
paddingBefore[column] = pgu.getBorders().getPaddingBefore(false, pgu.getCellLM());
paddingAfter[column] = pgu.getBorders().getPaddingAfter(false, pgu.getCellLM());
@@ -247,6 +248,8 @@
startRow[column] = activeRow;
keepWithNextSignals[column] = false;
forcedBreaks[column] = false;
+ } else {
+ log.trace("TableStepper.setupElementList: not empty nor primary grid unit");
}
}
@@ -541,8 +544,8 @@
}
}
if (log.isTraceEnabled()) {
- log.trace("borders before=" + borderBefore[i] + " after=" + borderAfter[i]);
- log.trace("padding before=" + paddingBefore[i] + " after=" + paddingAfter[i]);
+ log.trace("column " + i + ": borders before=" + borderBefore[i] + " after=" + borderAfter[i]);
+ log.trace("column " + i + ": padding before=" + paddingBefore[i] + " after=" + paddingAfter[i]);
}
}
if (seqCount == 0) {
@@ -601,7 +604,7 @@
}
}
if (log.isDebugEnabled()) {
- /*StringBuffer*/ sb = new StringBuffer();
+ /*StringBuffer*/ sb = new StringBuffer("[col nb: start-end(width)] ");
for (int i = 0; i < widths.length; i++) {
if (end[i] >= start[i]) {
sb.append(i + ": " + start[i] + "-" + end[i] + "(" + widths[i] + "), ");
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
Re: svn commit: r512266 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
Posted by Vincent Hennebert <vi...@anyware-tech.com>.
Jeremias Maerki a écrit :
> Vincent,
>
> can I please ask you to put code guards (if (log.isDebugEnabled())...)
> around debug and trace log statements? This avoids unnecessary string
> concatenation if the respective log level is diabled.
> See also: http://jakarta.apache.org/commons/logging/guide.html#Code_Guards
Sure, done.
Vincent
Re: svn commit: r512266 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Vincent,
can I please ask you to put code guards (if (log.isDebugEnabled())...)
around debug and trace log statements? This avoids unnecessary string
concatenation if the respective log level is diabled.
See also: http://jakarta.apache.org/commons/logging/guide.html#Code_Guards
Thanks!
On 27.02.2007 15:50:56 vhennebert wrote:
> Author: vhennebert
> Date: Tue Feb 27 06:50:52 2007
> New Revision: 512266
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=512266
> Log:
> Add log messages to help understand the code
>
> Modified:
> xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
>
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java?view=diff&rev=512266&r1=512265&r2=512266
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/table/TableStepper.java Tue Feb 27 06:50:52 2007
<snip/>
> @@ -238,6 +238,7 @@
> borderBefore[column] = pgu.getBorders().getBorderBeforeWidth(false);
> } else {
> borderBefore[column] = pgu.getBorders().getBorderBeforeWidth(false) / 2;
> + log.trace("border before for column " + column + ": " + borderBefore[column]);
> }
> paddingBefore[column] = pgu.getBorders().getPaddingBefore(false, pgu.getCellLM());
> paddingAfter[column] = pgu.getBorders().getPaddingAfter(false, pgu.getCellLM());
<snip/>
Jeremias Maerki