You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/26 12:53:45 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #8723: [Transaction] Fix transaction log replay not handle right.
congbobo184 opened a new pull request #8723:
URL: https://github.com/apache/pulsar/pull/8723
## Motivation
1. Transaction log replay don't handle right, because when replay compare lastConfirm.entryId, it is not right to replay.
2. Transaction handle proto is async, but recycle the command will happen before send response, we use requestId or others will not right.
3. We should afferent the managedLedgerConfig when we use MLTransactionLog, we can config the TransactionLog manageLedger.
4. add the TransactionNotFound exception in proto, it will return when transaction commit or abort and others transaction operation repeat or error handle.
## implement
1. we compare the markerDeletePosition and lastConfirmPosition to replay.
2. use local variable replace command get method.
3. afferent the managedLedgerConfig.
### Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (yes)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #8723: [Transaction] Fix transaction log replay not handle right.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8723:
URL: https://github.com/apache/pulsar/pull/8723#issuecomment-735491545
/pulsarbot run-failure-checkss
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 removed a comment on pull request #8723: [Transaction] Fix transaction log replay not handle right.
Posted by GitBox <gi...@apache.org>.
congbobo184 removed a comment on pull request #8723:
URL: https://github.com/apache/pulsar/pull/8723#issuecomment-735491545
/pulsarbot run-failure-checkss
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #8723: [Transaction] Fix transaction log replay not handle right.
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #8723:
URL: https://github.com/apache/pulsar/pull/8723#issuecomment-735492555
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8723: [Transaction] Fix transaction log replay not handle right.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8723:
URL: https://github.com/apache/pulsar/pull/8723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8723: [Transaction] Fix transaction log replay not handle right.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8723:
URL: https://github.com/apache/pulsar/pull/8723#issuecomment-737107495
/pulsarbot cherry-pick to branch-2.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org