[PATCH] EntityEnclosingMethod 'modality' fix

[Oleg Kalnichevski <o....@dplanet.ch>]

Folks,
Here's the draft version of the patch intended to fix the problem
reported by Andre John Mas (Order of methods in PostMethod) 

Please let me know what you think

Cheers

Oleg

Re: [PATCH] EntityEnclosingMethod 'modality' fix

[Michael Becke <be...@u.washington.edu>]

Hi Oleg,

I have a few comments.

- PostMethod.setRequestBody(NameValuePair[]) is still using the charset  
though I am guessing it probably should not.
- getRequestBody() and getRequestBodyAsString() now buffer the input  
stream.  Though I understand why this is being done I don't really like  
it.  It takes us back to the problem of not being able to repost a  
stream request body more than once.  It also makes me wonder what the  
use case is for getRequestBody*().
- if we are going to buffer content in getRequestBody*() I think there  
is a little duplication of work between these methods and  
bufferContent().

Mike

On Sunday, April 13, 2003, at 06:15 AM, Oleg Kalnichevski wrote:

> Folks,
> Here's the draft version of the patch intended to fix the problem
> reported by Andre John Mas (Order of methods in PostMethod)
>
> Please let me know what you think
>
> Cheers
>
> Oleg
> <post.patch>----------------------------------------------------------- 
> ----------
> To unsubscribe, e-mail:  
> commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:  
> commons-httpclient-dev-help@jakarta.apache.org