You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/05 07:52:18 UTC

[GitHub] [hbase] binlijin commented on a change in pull request #1110: HBASE-23761: The new cache entry can overflow the maxSize in CachedEn…

binlijin commented on a change in pull request #1110: HBASE-23761: The new cache entry can overflow the maxSize in CachedEn…
URL: https://github.com/apache/hbase/pull/1110#discussion_r374547943
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruCachedBlockQueue.java
 ##########
 @@ -65,14 +65,15 @@ public LruCachedBlockQueue(long maxSize, long blockSize) {
    * @param cb block to try to add to the queue
    */
   public void add(LruCachedBlock cb) {
-    if(heapSize < maxSize) {
+    long cbSize = cb.heapSize();
+    if(heapSize + cbSize < maxSize) {
 
 Review comment:
   format code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services