[GitHub] [inlong] healchow commented on a diff in pull request #5925: [INLONG-5924][DataProxy] Supplementary monitoring indicator dimension items

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5925:
URL: https://github.com/apache/inlong/pull/5925#discussion_r973676214


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/http/HttpBaseSource.java:
##########
@@ -77,7 +78,12 @@ public synchronized void start() {
                     statIntervalSec, maxMonitorCnt);
         }
         // register metrics
-        this.metricItemSet = new DataProxyMetricItemSet(this.getName());
+        ConfigManager configManager = ConfigManager.getInstance();
+        String clusterId =
+                configManager.getCommonProperties().getOrDefault(
+                        ConfigConstants.PROXY_CLUSTER_NAME, "DataProxy");

Review Comment:
   Suggest adding a constant for the default cluster value, such as `DEFAULT_PROXY_CLUSTER_NAME`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org