[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #809: GUACAMOLE-926: Batch Connection Import

["mike-jumper (via GitHub)" <gi...@apache.org>]

mike-jumper commented on code in PR #809:
URL: https://github.com/apache/guacamole-client/pull/809#discussion_r1140426543


##########
doc/licenses/csv-6.2.5/dep-coordinates.txt:
##########
@@ -0,0 +1,2 @@
+csv:6.2.5
+csv-parse:5.3.3

Review Comment:
   csv-parse v5.3.3 is part of csv v6.2.5?



##########
doc/licenses/core-util-is-1.0.3/README:
##########
@@ -0,0 +1,7 @@
+core-util-is (https://github.com/isaacs/core-util-is)
+---------------------------------------------
+
+    Version: 1.0.3
+    From: 'isaacs' (https://github.com/isaacs)

Review Comment:
   According to the license, this should be "Node.js contributors".



##########
doc/licenses/ieee754-1.2.1/README:
##########
@@ -0,0 +1,7 @@
+ieee754 (https://github.com/feross/ieee754)
+---------------------------------------------
+
+    Version: 1.2.1
+    From: 'Feross Aboukhadijeh' (https://github.com/feross)

Review Comment:
   According to the license, copyright on this is from "Fair Oaks Labs, Inc.".



##########
doc/licenses/readable-stream-2.3.7/README:
##########
@@ -0,0 +1,8 @@
+readable-stream (https://github.com/nodejs/readable-stream)
+---------------------------------------------
+
+    Version: 2.3.7
+    From: 'Node.js' (https://github.com/nodejs)

Review Comment:
   According to the license, this should be "Node.js contributors, Joyent, Inc., and other Node contributors".



##########
doc/licenses/stream-browserify-2.0.2/README:
##########
@@ -0,0 +1,8 @@
+stream-browserify (https://github.com/browserify/stream-browserify)
+---------------------------------------------
+
+    Version: 2.0.2
+    From: 'browserify' (https://github.com/browserify)

Review Comment:
   From the license, this should be "James Halliday".



##########
doc/licenses/setimmediate-1.0.5/README:
##########
@@ -0,0 +1,8 @@
+setImmediate.js (https://github.com/YuzuJS/setImmediate)
+---------------------------------------------
+
+    Version: 1.0.5
+    From: 'Yuzu (by Barnes & Noble Education)' (https://github.com/YuzuJS)
+    License(s):
+        MIT (bundled/setimmediate-1.0.5/LICENSE)

Review Comment:
   The bundled file is actually `LICENSE.txt`.



##########
doc/licenses/timers-browserify-2.0.12/README:
##########
@@ -0,0 +1,8 @@
+timers-browserify (https://github.com/browserify/timers-browserify)
+---------------------------------------------
+
+    Version: 2.0.12
+    From: 'browserify' (https://github.com/browserify)

Review Comment:
   According to the license, this should be "J. Ryan Stinnett".



##########
doc/licenses/csv-6.2.5/README:
##########
@@ -0,0 +1,7 @@
+node-csv (https://github.com/adaltas/node-csv)
+---------------------------------------------
+
+    Version: 6.2.5
+    From: 'adaltas' (https://github.com/adaltas)

Review Comment:
   This should be "Adaltas", apparently the name of a company.



##########
doc/licenses/timers-browserify-2.0.12/README:
##########
@@ -0,0 +1,8 @@
+timers-browserify (https://github.com/browserify/timers-browserify)
+---------------------------------------------
+
+    Version: 2.0.12
+    From: 'browserify' (https://github.com/browserify)
+    License(s):
+        MIT (bundled/timers-browserify-2.0.12/LICENSE)

Review Comment:
   The bundled file is actually `LICENSE.md`.



##########
doc/licenses/events-3.3.0/README:
##########
@@ -0,0 +1,7 @@
+events (https://github.com/browserify/events)
+---------------------------------------------
+
+    Version: 3.3.0
+    From: 'browserify' (https://github.com/browserify)

Review Comment:
   According to the license, this should be "Joyent, Inc. and other Node contributors."



##########
doc/licenses/process-nextick-args-2.0.1/README:
##########
@@ -0,0 +1,8 @@
+process-nextick-args (https://github.com/calvinmetcalf/process-nextick-args)
+---------------------------------------------
+
+    Version: 2.0.1
+    From: 'Calvin Metcalf' (https://github.com/calvinmetcalf)
+    License(s):
+        MIT (bundled/process-nextick-args-2.0.1/LICENSE)

Review Comment:
   The bundled file is actually `license.md`.



##########
doc/licenses/string_decoder-1.1.1/README:
##########
@@ -0,0 +1,8 @@
+string_decoder (https://github.com/nodejs/string_decoder)
+---------------------------------------------
+
+    Version: 1.1.1
+    From: 'Node.js' (https://github.com/nodejs)

Review Comment:
   According to the license, this should be "Node.js contributors, Joyent, Inc., and other Node contributors".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org