Re: [PR] feat: Expose used `MemoryPool` details in `ResourcesExhausted` error messages [datafusion]

["nathanb9 (via GitHub)" <gi...@apache.org>]

nathanb9 commented on code in PR #20387:
URL: https://github.com/apache/datafusion/pull/20387#discussion_r3108002456


##########
datafusion/execution/src/memory_pool/pool.rs:
##########
@@ -362,6 +421,22 @@ pub struct TrackConsumersPool<I> {
     tracked_consumers: Mutex<HashMap<usize, TrackedConsumer>>,
 }
 
+impl<I: MemoryPool> Display for TrackConsumersPool<I> {
+    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
+        // let tracked_consumers = self.tracked_consumers.lock();

Review Comment:
   small but what is this comments purpose?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org