You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Tim Armstrong (Jira)" <ji...@apache.org> on 2020/06/13 00:09:00 UTC

[jira] [Resolved] (IMPALA-3636) Regression in DecimalOperators::EQ with codegen disabled

     [ https://issues.apache.org/jira/browse/IMPALA-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-3636.
-----------------------------------
    Resolution: Won't Fix

> Regression in DecimalOperators::EQ with codegen disabled
> --------------------------------------------------------
>
>                 Key: IMPALA-3636
>                 URL: https://issues.apache.org/jira/browse/IMPALA-3636
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>    Affects Versions: Impala 2.6.0
>            Reporter: Mostafa Mokhtar
>            Priority: Minor
>              Labels: performance, regression
>
> Some of the decimal improvements that came in Impala 2.6 introduced a regression in the none-codegened path.
> This regression was cause by https://github.com/cloudera/Impala/blob/cdh5-trunk/testdata/workloads/targeted-perf/queries/primitive_orderby_all.test. 
> After
> ||Function Stack||CPU Time: Total||
> |impala::DecimalOperators::Eq_DecimalVal_DecimalVal|62.207s|
> |  --impala::Expr::GetConstantInt|55.458s|
> |  --impala::DecimalValue<long>::Eq|1.480s|
> |  --impala::GetDecimal8Value|0.290s|
> |  --impala::DecimalValue<__int128>::Eq|0.190s|
>   
>  Before 
> ||Function Stack||CPU Time: Total||
> |impala::DecimalOperators::Eq_DecimalVal_DecimalVal|9.809s|
> |  --impala::DecimalValue<long>::Compare|2.300s|
> |  --impala_udf::FunctionContext::GetArgType|2.130s|
> |  --func@0x812950|0.390s|
> This is a simplified version of the query which can be used as a repro
> {code}
> select *
> FROM (
>   SELECT Rank() OVER (
>       ORDER BY l_extendedprice
>         ,l_quantity
>         ,l_discount
>         ,l_tax
>       ) AS rank
>   FROM lineitem
>   WHERE l_shipdate < '1992-05-09'
>   ) a
> WHERE rank < 10
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org