You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hgschmie (via GitHub)" <gi...@apache.org> on 2023/08/17 05:09:38 UTC
[GitHub] [maven-javadoc-plugin] hgschmie opened a new pull request, #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
hgschmie opened a new pull request, #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225
When using an exclude filter, it is possible that the plugin creates
javadoc --patch-module command line options, that do not actually have
a value.
This changes skips such empty entries.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
}
for (Entry<String, Collection<Path>> entry : patchModules.entrySet()) {
- addArgIfNotEmpty(
- arguments,
- "--patch-module",
- entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
- false,
- false);
+ if (!entry.getValue().isEmpty()) {
+ addArgIfNotEmpty(
+ arguments,
+ "--patch-module",
+ entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
+ false,
+ false);
+ }
Review Comment:
Is it possible to add a test (unit or IT) for verifying this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] hgschmie merged pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie merged PR #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-767] javadoc creates invalid --patch-module statements [maven-javadoc-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-2957400964
Resolve #1141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] hgschmie commented on pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
Posted by "hgschmie (via GitHub)" <gi...@apache.org>.
hgschmie commented on PR #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1683340371
added integration test. To try out, remove this line: https://github.com/apache/maven-javadoc-plugin/pull/225/files#diff-3cc042c3116d0543702076b295213a5b4058ce2f0c342edf234dfd06fefacabfR44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1681886572
please remember to add jira number in final commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #225:
URL: https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
}
for (Entry<String, Collection<Path>> entry : patchModules.entrySet()) {
- addArgIfNotEmpty(
- arguments,
- "--patch-module",
- entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
- false,
- false);
+ if (!entry.getValue().isEmpty()) {
+ addArgIfNotEmpty(
+ arguments,
+ "--patch-module",
+ entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
+ false,
+ false);
+ }
Review Comment:
Is it possible to add a test (unit or IT) for verifying this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org