You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/06/28 04:00:20 UTC
[GitHub] zeppelin pull request #2447: [ZEPPELIN-2700] Provide a link to interpreter b...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2447
[ZEPPELIN-2700] Provide a link to interpreter binding mode doc
### What is this PR for?
Provide a link to the interpreter binding mode documentation page in the interpreter page to help understand what this feature is for (`usage/interpreter/interpreter_binding_mode.html`)
- **documentation is not deployed to web yet. So clicking this icon will redirect to you to 404 page**
### What type of PR is it?
[Improvement | Documentation]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2700](https://issues.apache.org/jira/browse/ZEPPELIN-2700)
### How should this be tested?
1. Open the interpreter page
2. Check the links (URL, icon, ..)
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2700/provide-link-for-interpreter-binding-mode-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2447
----
commit 2291e63a0945e310660f92a5c80bdcce13e817fe
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-28T03:33:54Z
style: reindent html
commit 72d6c063579c98df18f0672eb037a60f0af1fb45
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-28T03:37:23Z
fix: Remove useless margin-bottom
commit 41261239dcb1f4e5f16b5fd01bafcb79c286ad8e
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-28T03:55:24Z
feat: Add link to interpreter mode doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2447: [ZEPPELIN-2700] Provide a link to interpreter binding ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2447
merge if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2447: [ZEPPELIN-2700] Provide a link to interpreter b...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2447
[ZEPPELIN-2700] Provide a link to interpreter binding mode doc
### What is this PR for?
Provide a link to the interpreter binding mode documentation page in the interpreter page to help understand what this feature is for (`usage/interpreter/interpreter_binding_mode.html`)
- **documentation is not deployed to web yet. So clicking this icon will redirect you to 404 page**
### What type of PR is it?
[Improvement | Documentation]
### Todos
DONE
### What is the Jira issue?
[ZEPPELIN-2700](https://issues.apache.org/jira/browse/ZEPPELIN-2700)
### How should this be tested?
1. Open the interpreter page
2. Check the links (URL, icon, ..)
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2700/provide-link-for-interpreter-binding-mode-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2447
----
commit 2291e63a0945e310660f92a5c80bdcce13e817fe
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-28T03:33:54Z
style: reindent html
commit 72d6c063579c98df18f0672eb037a60f0af1fb45
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-28T03:37:23Z
fix: Remove useless margin-bottom
commit 41261239dcb1f4e5f16b5fd01bafcb79c286ad8e
Author: 1ambda <1a...@gmail.com>
Date: 2017-06-28T03:55:24Z
feat: Add link to interpreter mode doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2447: [ZEPPELIN-2700] Provide a link to interpreter binding ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2447
Ready to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2447: [ZEPPELIN-2700] Provide a link to interpreter b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2447: [ZEPPELIN-2700] Provide a link to interpreter binding ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2447
Thanks for the review @felixcheung, I updated the tooltip message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2447: [ZEPPELIN-2700] Provide a link to interpreter binding ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2447
CI failed but irrelevant.
- https://travis-ci.org/1ambda/zeppelin/jobs/247790231
```java
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 145.149 sec - in org.apache.zeppelin.integration.AuthenticationIT
Results :
Tests in error:
ZeppelinIT.testSparkInterpreterDependencyLoading:249->AbstractZeppelinIT.waitForParagraph:68->AbstractZeppelinIT.pollingWait:94 » Timeout
Tests run: 24, Failures: 0, Errors: 1, Skipped: 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2447: [ZEPPELIN-2700] Provide a link to interpreter binding ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2447
Updating doc is discussed in https://github.com/apache/zeppelin/pull/2437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2447: [ZEPPELIN-2700] Provide a link to interpreter b...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---