[GitHub] [iceberg] openinx commented on a change in pull request #1741: Flink: add maxParallelism method to method chain in flink RewriteDataFilesAction

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #1741:
URL: https://github.com/apache/iceberg/pull/1741#discussion_r521776315



##########
File path: flink/src/main/java/org/apache/iceberg/flink/actions/RewriteDataFilesAction.java
##########
@@ -61,8 +61,9 @@ protected RewriteDataFilesAction self() {
     return this;
   }
 
-  public void maxParallelism(int parallelism) {
+  public RewriteDataFilesAction maxParallelism(int parallelism) {

Review comment:
       I think it's OK to use `maxParallelism(..)`  because the base class `BaseRewriteDataFilesAction` also have the setter method without the prefix `set`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org