You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wido <gi...@git.apache.org> on 2015/09/25 11:01:18 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/889
CLOUDSTACK-8879: Depend in rados-java 0.2.0
This should fix the CloudStack Agent from crashing when it has to
handle more then 16 RBD snapshots on one Volume.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wido/cloudstack CLOUDSTACK-8879
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/889.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #889
----
commit d413b2c375c2e5c2a0ebeca1fae07c942892ac71
Author: Wido den Hollander <wi...@widodh.nl>
Date: 2015-09-25T08:16:24Z
CLOUDSTACK-8879: Depend in rados-java 0.2.0
This should fix the CloudStack Agent from crashing when it has to
handle more then 16 RBD snapshots on one Volume.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144654663
@remibergsma @runseb I've ran the test_vm_lifecycle.
[root@cs1 smoke]# nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a tags=basic,required_hardware=false test_vm_life_cycle
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp//MarvinLogs//Oct_01_2015_10_11_33_MFQA0G. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_deploy_vm | Status : SUCCESS ===
=== TestName: test_deploy_vm_multiple | Status : SUCCESS ===
=== TestName: test_01_stop_vm | Status : SUCCESS ===
=== TestName: test_02_start_vm | Status : SUCCESS ===
=== TestName: test_03_reboot_vm | Status : SUCCESS ===
=== TestName: test_06_destroy_vm | Status : SUCCESS ===
=== TestName: test_07_restore_vm | Status : SUCCESS ===
=== TestName: test_09_expunge_vm | Status : SUCCESS ===
===final results are now copied to: /tmp//MarvinLogs//16ORAQ===
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144346920
@borisroman thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144709586
Perhaps a manual test to fire the BackupSnapshot command?
Is there any integration test that we can execute to cover it?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-143480210
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144346818
Will do.
Best regards,
Boris Schrijver
TEL: +31633784542
MAIL: boris@pcextreme.nl
> On September 30, 2015 at 12:11 PM Remi Bergsma <no...@github.com>
> wrote:
>
>
> @wido <https://github.com/wido> maybe @borisroman
> <https://github.com/borisroman> can execute smoke/test_vm_life_cycle.py to do
> a quick check?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/889#issuecomment-144346492> .
>
>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144712407
@wilderrodrigues A proper integration test for Ceph is still on my whishlist, but to do that we need a running Ceph cluster which we can talk against.
I wrote rados-java btw and I solved some bugs in those bindings. They are passing all my unit tests which actually talk to a Ceph cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-146536044
@remibergsma @wilderrodrigues I ran the requested tests, passing successfully. Integration tests aren't yet around, mocking Ceph (or using a real deployment) and writing those tests will take a lot of time. We confirmed it worked be manually testing it.
As 4.6 release is close I would like this to be merged before release. The PR has three LGTM's including one with test results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144322421
@runseb No, not really. All my Unit tests are succeeding on rados-java itself. It should work as expected. But I have no in CloudStack test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144315290
LGTM, small change.
@wido what tests can be run to check for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-146861091
Agree to merge this small bugfix. Thanks for running the lifecycle test to be sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144346492
@wido maybe @borisroman can execute smoke/test_vm_life_cycle.py to do a quick check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8879: Depend in rados-java 0.2...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/889
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---