You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/12/11 14:18:27 UTC

[I] Add e2e testing for "dag.test()` [airflow]

potiuk opened a new issue, #59319:
URL: https://github.com/apache/airflow/issues/59319

   ### Body
   
   The `dag.test` is not very unit-testable, especially with `executor=True` - but it would be great to have some e2e tests showing that it works.
   
   Follow up after #59314
   
   ### Committer
   
   - [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add e2e testing for "dag.test()` [airflow]

Posted by "sejal-gupta-ksolves (via GitHub)" <gi...@apache.org>.
sejal-gupta-ksolves commented on issue #59319:
URL: https://github.com/apache/airflow/issues/59319#issuecomment-4715207028

   Hi @potiuk, I would like to work on it. I'll be raising PR shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add e2e testing for "dag.test()` [airflow]

Posted by "venkatamandavilli-code (via GitHub)" <gi...@apache.org>.
venkatamandavilli-code commented on issue #59319:
URL: https://github.com/apache/airflow/issues/59319#issuecomment-4724939371

   Thanks for the detailed investigation and reproduction steps.
   
   The observation that the behavior disappears when `logical_date=None` is specified seems like a very useful clue.
   
   From a DAG versioning perspective, I would expect versions to change when the DAG definition changes, not when a DAG is executed. If a runtime-generated timestamp is being included in the serialized representation used for version comparison, that could explain why a new version is created for every run.
   
   The fact that removing the `TriggerDagRunOperator` also resolves the issue seems to further suggest that the operator's default `logical_date` handling may be contributing dynamic content during serialization.
   
   This could have operational implications because frequent version changes may make it harder to use DAG versions for auditing, deployment validation, and troubleshooting.
   
   It may be worth checking whether the default `logical_date` value is evaluated during DAG parsing/serialization and whether it should be excluded from fields that participate in DAG version calculation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add e2e testing for "dag.test()` [airflow]

Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on issue #59319:
URL: https://github.com/apache/airflow/issues/59319#issuecomment-3645101345

   I will open a pr for this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add e2e testing for "dag.test()` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #59319:
URL: https://github.com/apache/airflow/issues/59319#issuecomment-3702132645

   Feel free


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add e2e testing for "dag.test()` [airflow]

Posted by "Shekharrajak (via GitHub)" <gi...@apache.org>.
Shekharrajak commented on issue #59319:
URL: https://github.com/apache/airflow/issues/59319#issuecomment-3701551038

   Hi @potiuk , I would like to work on it, I am already exploring the unit testable DAG.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add e2e testing for "dag.test()` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #59319:
URL: https://github.com/apache/airflow/issues/59319#issuecomment-3986421689

   @Shekharrajak We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes).
   
   This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready.
   
   We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org