[jira] [Work logged] (DBCP-509) Not all methods are consistent in PerUserPooldataSource and InstanceKeyDataSource

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-509?focusedWorklogId=480201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480201 ]

ASF GitHub Bot logged work on DBCP-509:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Sep/20 15:09
            Start Date: 08/Sep/20 15:09
    Worklog Time Spent: 10m 
      Work Description: garydgregory commented on pull request #14:
URL: https://github.com/apache/commons-dbcp/pull/14#issuecomment-688942762


   @kinow 
   Closing since it breaks BC and there is no further activity.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 480201)
    Time Spent: 20m  (was: 10m)

> Not all methods are consistent in PerUserPooldataSource and InstanceKeyDataSource
> ---------------------------------------------------------------------------------
>
>                 Key: DBCP-509
>                 URL: https://issues.apache.org/jira/browse/DBCP-509
>             Project: Commons DBCP
>          Issue Type: Improvement
>    Affects Versions: 2.4.0
>            Reporter: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 2.8.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> While working on DBCP-504 tests, I wrote a few files to help me automating some of the tests (e.g. https://gist.github.com/kinow/053b6d1f293fdc208a2a14571f246786).
> In PerUserPooldataSource, I realized I had to change some tests that were failing to handle null values. But not all methods. So I had a look at the methods, and the majority was following a pattern
> * using primitives
> * default'ing to the class/parent method getDefaultPropertyZ() whenever Z property was null
> But three values were using objects instead of primitives, and allowing null's:
> * defaultAutoCommit
> * defaultReadOnly
> * perUserDefaultAutoCommit
> I prepared a pull request that falls back to the default method's values.
> It's more of a discussion issue, just to document what I found during DBCP-504.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)