You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alex Petrov (JIRA)" <ji...@apache.org> on 2016/08/19 16:18:20 UTC

[jira] [Comment Edited] (CASSANDRA-11031) MultiTenant : support “ALLOW FILTERING" for Partition Key

    [ https://issues.apache.org/jira/browse/CASSANDRA-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428384#comment-15428384 ] 

Alex Petrov edited comment on CASSANDRA-11031 at 8/19/16 4:18 PM:
------------------------------------------------------------------

[~jasonstack] I've fixed most of problems with dtests by now. [Unit tests|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11031-trunk-testall/] look good. However, ordering was not correct in limit tests,{{PER PARTITION LIMIT}} tests and test with {{ORDER BY}} clause were absent. Could you please add those? You can use [my branch|https://github.com/ifesdjeen/cassandra-dtest/tree/11031-trunk] as a base for further commits.

Please, use {{assert_all}} with {{ignore_order}} if results return more than one partition as their order is not guaranteed. {{LIMIT}} tests are quite tricky. The easiest would probably be to make sure you know which partition you're going to be getting back first, this way order will be consistent. Otherwise you have to compare with contents of all possible partitions.


was (Author: ifesdjeen):
[~jasonstack] I've fixed most of problems with dtests by now. Unit tests look good. However, ordering was not correct in limit tests,{{PER PARTITION LIMIT}} tests and test with {{ORDER BY}} clause were absent. Could you please add those?

Please, use {{assert_all}} with {{ignore_order}} if results return more than one partition as their order is not guaranteed. {{LIMIT}} tests are quite tricky. The easiest would probably be to make sure you know which partition you're going to be getting back first, this way order will be consistent. Otherwise you have to compare with contents of all possible partitions.

> MultiTenant : support “ALLOW FILTERING" for Partition Key
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-11031
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11031
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: CQL
>            Reporter: ZhaoYang
>            Assignee: ZhaoYang
>            Priority: Minor
>             Fix For: 3.x
>
>
> Currently, Allow Filtering only works for secondary Index column or clustering columns. And it's slow, because Cassandra will read all data from SSTABLE from hard-disk to memory to filter.
> But we can support allow filtering on Partition Key, as far as I know, Partition Key is in memory, so we can easily filter them, and then read required data from SSTable.
> This will similar to "Select * from table" which scan through entire cluster.
> CREATE TABLE multi_tenant_table (
> 	tenant_id text,
> 	pk2 text,
> 	c1 text,
> 	c2 text,
> 	v1 text,
> 	v2 text,
> 	PRIMARY KEY ((tenant_id,pk2),c1,c2)
> ) ;
> Select * from multi_tenant_table where tenant_id = "datastax" allow filtering;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)