You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/06/07 12:36:35 UTC

Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/
-----------------------------------------------------------

Review request for cloudstack and Devdeep Singh.


Description
-------

When multiple vlan ranges are added to a physical networks the vlan ranges displayed in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges were added,Instead if they are displayed in the ascending order range this would make it easy for the end user.


This addresses bug CLOUDSTACK-2167.


Diffs
-----

  server/src/com/cloud/api/ApiResponseHelper.java bcc1605 

Diff: https://reviews.apache.org/r/11708/diff/


Testing
-------

The response of list api is now enhanced:
<listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
<count>1</count>
<physicalnetwork>
<id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
<name>Physical Network 1</name>
<broadcastdomainrange>ZONE</broadcastdomainrange>
<zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
<state>Enabled</state>
<vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
<isolationmethods>VLAN</isolationmethods>
</physicalnetwork>
</listphysicalnetworksresponse>
Build passes successfully.


Thanks,

Saksham Srivastava

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review21570
-----------------------------------------------------------



server/src/com/cloud/api/ApiResponseHelper.java
<https://reviews.apache.org/r/11708/#comment44617>

    How about using the StringUtils.join? It'll remove the need of appending the string together and them trimming it to remove the trailing separator.


- Devdeep Singh


On June 7, 2013, 10:36 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11708/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 10:36 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> -------
> 
> When multiple vlan ranges are added to a physical networks the vlan ranges displayed in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges were added,Instead if they are displayed in the ascending order range this would make it easy for the end user.
> 
> 
> This addresses bug CLOUDSTACK-2167.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java bcc1605 
> 
> Diff: https://reviews.apache.org/r/11708/diff/
> 
> 
> Testing
> -------
> 
> The response of list api is now enhanced:
> <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
> <count>1</count>
> <physicalnetwork>
> <id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
> <name>Physical Network 1</name>
> <broadcastdomainrange>ZONE</broadcastdomainrange>
> <zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
> <state>Enabled</state>
> <vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
> <isolationmethods>VLAN</isolationmethods>
> </physicalnetwork>
> </listphysicalnetworksresponse>
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22148
-----------------------------------------------------------

Ship it!


Ship It!

- Likitha Shetty


On June 19, 2013, 11:37 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11708/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> -------
> 
> When multiple vlan ranges are added to a physical networks the vlan ranges displayed in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges were added,Instead if they are displayed in the ascending order range this would make it easy for the end user.
> 
> 
> This addresses bug CLOUDSTACK-2167.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f 
> 
> Diff: https://reviews.apache.org/r/11708/diff/
> 
> 
> Testing
> -------
> 
> The response of list api is now enhanced:
> <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
> <count>1</count>
> <physicalnetwork>
> <id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
> <name>Physical Network 1</name>
> <broadcastdomainrange>ZONE</broadcastdomainrange>
> <zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
> <state>Enabled</state>
> <vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
> <isolationmethods>VLAN</isolationmethods>
> </physicalnetwork>
> </listphysicalnetworksresponse>
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22149
-----------------------------------------------------------


Commit e420c3be8c597da6abf8915a99b0e3f860fda034 in branch refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e420c3b ]

CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order


- ASF Subversion and Git Services


On June 19, 2013, 11:37 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11708/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> -------
> 
> When multiple vlan ranges are added to a physical networks the vlan ranges displayed in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges were added,Instead if they are displayed in the ascending order range this would make it easy for the end user.
> 
> 
> This addresses bug CLOUDSTACK-2167.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f 
> 
> Diff: https://reviews.apache.org/r/11708/diff/
> 
> 
> Testing
> -------
> 
> The response of list api is now enhanced:
> <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
> <count>1</count>
> <physicalnetwork>
> <id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
> <name>Physical Network 1</name>
> <broadcastdomainrange>ZONE</broadcastdomainrange>
> <zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
> <state>Enabled</state>
> <vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
> <isolationmethods>VLAN</isolationmethods>
> </physicalnetwork>
> </listphysicalnetworksresponse>
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/#review22150
-----------------------------------------------------------


Commit fd77b60c5d3a3a5029d40583d4fc391e0cb41253 in branch refs/heads/master-6-17-stable from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fd77b60 ]

CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order


- ASF Subversion and Git Services


On June 19, 2013, 11:37 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11708/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 11:37 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Description
> -------
> 
> When multiple vlan ranges are added to a physical networks the vlan ranges displayed in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges were added,Instead if they are displayed in the ascending order range this would make it easy for the end user.
> 
> 
> This addresses bug CLOUDSTACK-2167.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f 
> 
> Diff: https://reviews.apache.org/r/11708/diff/
> 
> 
> Testing
> -------
> 
> The response of list api is now enhanced:
> <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
> <count>1</count>
> <physicalnetwork>
> <id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
> <name>Physical Network 1</name>
> <broadcastdomainrange>ZONE</broadcastdomainrange>
> <zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
> <state>Enabled</state>
> <vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
> <isolationmethods>VLAN</isolationmethods>
> </physicalnetwork>
> </listphysicalnetworksresponse>
> Build passes successfully.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11708/
-----------------------------------------------------------

(Updated June 19, 2013, 11:37 a.m.)


Review request for cloudstack and Devdeep Singh.


Changes
-------

Updated diff with incorporated suggestions.


Description
-------

When multiple vlan ranges are added to a physical networks the vlan ranges displayed in the output of the listPhysicalNetworks api displays the vlan range in the order the ranges were added,Instead if they are displayed in the ascending order range this would make it easy for the end user.


This addresses bug CLOUDSTACK-2167.


Diffs (updated)
-----

  server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f 

Diff: https://reviews.apache.org/r/11708/diff/


Testing
-------

The response of list api is now enhanced:
<listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT">
<count>1</count>
<physicalnetwork>
<id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id>
<name>Physical Network 1</name>
<broadcastdomainrange>ZONE</broadcastdomainrange>
<zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid>
<state>Enabled</state>
<vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan>
<isolationmethods>VLAN</isolationmethods>
</physicalnetwork>
</listphysicalnetworksresponse>
Build passes successfully.


Thanks,

Saksham Srivastava