You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/08 02:39:32 UTC
[GitHub] [superset] mayurnewase opened a new pull request #18610: feature: Custom content in alert and reports
mayurnewase opened a new pull request #18610:
URL: https://github.com/apache/superset/pull/18610
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] gkachru commented on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
gkachru commented on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1035996261
hi @yousoph
I haven't worked on this pull request, but I would like to see this feature added as well. My use case is to add multiple call-to-actions for other systems (like Approve or Create Task etc) for people who may not have access to superset but may need to act on the information provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase edited a comment on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
mayurnewase edited a comment on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1036369003
I thought the simple text in description field wasn't enough to send descriptive reports, so wanted to add text editor for html and markdown for different delivery methods.
After above comments looks like there is some interest for it, so I might complete this feature over weekend and mark ready for review.
We can maybe treat description just to describe the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase edited a comment on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
mayurnewase edited a comment on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1036369003
I thought the simple text in description field wasn't enough to send descriptive reports, so wanted to add text editor for html and markdown for different delivery methods.
After above comments looks like there is some interest for it, so I might complete this feature over weekend and mark ready for review if needed or close if its an overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] chetank81 commented on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
chetank81 commented on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1036349608
While we sent the reports (like attachment) we want to send standard email template (in html format) which has ability to add external links, images (header) etc. Many organization need custom email templates to be use for sending different reports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1035581076
hi @mayurnewase !
The current description already gets sent in the body of the alert or report, so the message body field may be redundant.
What types of content are you looking to include in your alerts/reports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] chetank81 commented on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
chetank81 commented on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1039983327
@mayurnewase, @yousoph & @betodealmeida : When do we think we will have this feature avaiable in main branch? Very important feature for folks who wish to use superset as audit report tool in organization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1036369003
I thought the simple text in description field wasn't enough to send descriptive reports, so wanted to add text editor for html and markdown for different delivery methods.
After above comments looks like there is some interest for it, so I might complete this feature over weekend and mark ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] chetank81 commented on pull request #18610: feat: custom content in alert and reports
Posted by GitBox <gi...@apache.org>.
chetank81 commented on pull request #18610:
URL: https://github.com/apache/superset/pull/18610#issuecomment-1039983327
@mayurnewase, @yousoph & @betodealmeida : When do we think we will have this feature avaiable in main branch? Very important feature for folks who wish to use superset as audit report tool in organization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org