You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2013/07/31 21:35:50 UTC
[jira] [Resolved] (SOLR-3616) Solr
TestJmxIntegration#testJmxOnCoreReload bug related to TestHarness
[ https://issues.apache.org/jira/browse/SOLR-3616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-3616.
----------------------------
Resolution: Fixed
Fix Version/s: (was: 3.6)
(was: 3.5)
(was: 3.4)
from what i can tell reviewing the patch, and the current TestHarness code, this problem was resolved at some point in the recent past due to refactoring how the TestHarness dealt with core initialization.
(testJmxOnCoreReload still has issues - see SOLR-2715 -- but this no longer seems to be one of them)
> Solr TestJmxIntegration#testJmxOnCoreReload bug related to TestHarness
> ----------------------------------------------------------------------
>
> Key: SOLR-3616
> URL: https://issues.apache.org/jira/browse/SOLR-3616
> Project: Solr
> Issue Type: Bug
> Components: multicore
> Reporter: Emanuele Lombardi
> Labels: CoreReload, JMX
> Attachments: TestHarnessPatch.txt
>
>
> Using zabbix to monitor my Solr instance I noticed that after core reloading the Mbeans have disappeared. There is a test -> testJmxIntegration#testJmxOnCoreReload used to check Mbeans presence after core reload. The test is wrong because TestHarness sets core name to null on creating the core for the first time (CoreContainer#initialize) so his Mbeans have jmxRootName="solr" (JmxMonitoredMap#line61). Once the core is created it sets coreName = "" causing new Mbeans to have jmxRootName="solr/"
> So after first core closing only MBeans having name "solr" are removed and only MBeans with name "solr/" persists on JMXServer. This test is fake.
> Step to reproduce test fail
> 1) Apply TestHarness patch
> 2) Run the tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org