You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "jiayuasu (via GitHub)" <gi...@apache.org> on 2024/11/23 06:37:36 UTC

[PR] [SEDONA-680] Remove rasterio from mandatory dependencies [sedona]

jiayuasu opened a new pull request, #1692:
URL: https://github.com/apache/sedona/pull/1692

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-680. The PR name follows the format `[SEDONA-680] my subject`.
   
   ## What changes were proposed in this PR?
   
   This is to address several issues reported by users: #1688 #1574 #1607 
   
   1. Move rasterio dependency to optional dependencies
   2. Add explanation in doc
   
   ## How was this patch tested?
   
   Passed local test
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-680] Remove rasterio from mandatory dependencies [sedona]

Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.
Kontinuation commented on PR #1692:
URL: https://github.com/apache/sedona/pull/1692#issuecomment-2495386750

   > @Kontinuation Agree. Forgot that part. We need to bypass that part too. Please go ahead and append commits.
   
   Now it is working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-680] Remove rasterio from mandatory dependencies [sedona]

Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.
Kontinuation commented on PR #1692:
URL: https://github.com/apache/sedona/pull/1692#issuecomment-2495369658

   Simply changing the dependency to optional may not be sufficient. [sedona.sql.types](https://github.com/apache/sedona/blob/master/python/sedona/sql/types.py#L20) imports raster_serde, which imports rasterio transitively.
   
   I'll append new commits to this patch and run additional tests without rasterio installed on GitHub Actions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-680] Remove rasterio from mandatory dependencies [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on PR #1692:
URL: https://github.com/apache/sedona/pull/1692#issuecomment-2495370085

   @Kontinuation Agree. Forgot that part. We need to bypass that part too. Please go ahead and append commits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SEDONA-680] Remove rasterio from mandatory dependencies [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1692:
URL: https://github.com/apache/sedona/pull/1692


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org