[GitHub] [druid] gianm commented on pull request #14281: OBSDATA-440 Adding SegmentMetadataEvent and publishing them via KafkaEmitter

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on PR #14281:
URL: https://github.com/apache/druid/pull/14281#issuecomment-1548772012

   > Should I explicitly filter this new event type from these emitters?
   
   IMO it would make more sense to edit those emitters to ignore unknown event types.
   
   Btw, this may be OK for your use case, but, I wanted to point out that there is a race here: it's possible for the segments to be committed and for the server to crash before it emits this event. So, some might get missed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org