You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nlpcraft.apache.org by se...@apache.org on 2020/05/12 10:22:30 UTC

[incubator-nlpcraft-java-client] branch master updated: Pom fixes.

This is an automated email from the ASF dual-hosted git repository.

sergeykamov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft-java-client.git


The following commit(s) were added to refs/heads/master by this push:
     new 46d135a  Pom fixes.
46d135a is described below

commit 46d135a086fcb302efc823274673e967687a3593
Author: Sergey Kamov <se...@apache.org>
AuthorDate: Tue May 12 13:22:19 2020 +0300

    Pom fixes.
---
 pom.xml | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 51 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 2298a60..4ae367a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -42,6 +42,14 @@
         <maven.javadoc.plugin.ver>3.0.0-M1</maven.javadoc.plugin.ver>
         <maven.jar.plugin.ver>3.1.1</maven.jar.plugin.ver>
         <apache.rat.plugin.ver>0.13</apache.rat.plugin.ver>
+
+        <!--
+            NOTE: this library is NOT included in binary build and is optional
+            for NLPCraft. It is licensed under GPLv3 and has to be downloaded separately by
+            the end user, when required.
+            TODO: how to avoid set concrete version from main project?
+        -->
+        <stanford.corenlp.ver>3.9.2</stanford.corenlp.ver>
     </properties>
 
     <name>NLPCraft - Java Client</name>
@@ -280,6 +288,25 @@
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-shade-plugin</artifactId>
+                <version>${maven.shade.plugin.ver}</version>
+                <executions>
+                    <execution>
+                        <id>jar.all.deps</id>
+                        <phase>package</phase>
+                        <goals>
+                            <goal>shade</goal>
+                        </goals>
+                        <configuration>
+                            <outputFile>
+                                ${project.build.directory}/${project.artifactId}-${project.version}-all-deps.jar
+                            </outputFile>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-source-plugin</artifactId>
                 <version>${maven.source.plugin.ver}</version>
                 <executions>
@@ -315,6 +342,29 @@
                     <value>true</value>
                 </property>
             </activation>
+            <dependencies>
+                <!--Stanford NLP dependencies should be excluded from build zip.-->
+                <dependency>
+                    <groupId>edu.stanford.nlp</groupId>
+                    <artifactId>stanford-corenlp</artifactId>
+                    <version>${stanford.corenlp.ver}</version>
+                    <scope>provided</scope>
+                    <!-- org.apache.tika contains javax.activation. -->
+                    <exclusions>
+                        <exclusion>
+                            <groupId>javax.activation</groupId>
+                            <artifactId>javax.activation-api</artifactId>
+                        </exclusion>
+                    </exclusions>
+                </dependency>
+                <dependency>
+                    <groupId>edu.stanford.nlp</groupId>
+                    <artifactId>stanford-corenlp</artifactId>
+                    <version>${stanford.corenlp.ver}</version>
+                    <classifier>models</classifier>
+                    <scope>provided</scope>
+                </dependency>
+            </dependencies>
             <build>
                 <plugins>
                     <plugin>
@@ -357,7 +407,7 @@
                                 <id>sign-artifacts</id>
                                 <phase>verify</phase>
                                 <goals>
-                                    <goal>release</goal>
+                                    <goal>sign</goal>
                                 </goals>
                             </execution>
                         </executions>