You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2014/11/10 11:04:12 UTC
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is
missing from cluster level settings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 10:04 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-6465
https://issues.apache.org/jira/browse/CLOUDSTACK-6465
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
Diffs (updated)
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5
server/src/com/cloud/configuration/Config.java 5ac0e90
Diff: https://reviews.apache.org/r/20518/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is
missing from cluster level settings
Posted by Rajani Karuturi <ra...@apache.org>.
> On Nov. 25, 2014, 8:16 a.m., Rajani Karuturi wrote:
> > Ship It!
>
> Rajani Karuturi wrote:
> pushed to 4.5. commit eae733817b3670b0151410c027325f78013392ad
> will merge to master as well.
master 9585aa0b51a571d5ea3c33c98bec13f5230ecf4a
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/#review62955
-----------------------------------------------------------
On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20518/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:06 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6465
> https://issues.apache.org/jira/browse/CLOUDSTACK-6465
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5
> server/src/com/cloud/configuration/Config.java 5ac0e90
>
> Diff: https://reviews.apache.org/r/20518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is
missing from cluster level settings
Posted by Rajani Karuturi <ra...@apache.org>.
> On Nov. 25, 2014, 8:16 a.m., Rajani Karuturi wrote:
> > Ship It!
pushed to 4.5. commit eae733817b3670b0151410c027325f78013392ad
will merge to master as well.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/#review62955
-----------------------------------------------------------
On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20518/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:06 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6465
> https://issues.apache.org/jira/browse/CLOUDSTACK-6465
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5
> server/src/com/cloud/configuration/Config.java 5ac0e90
>
> Diff: https://reviews.apache.org/r/20518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is
missing from cluster level settings
Posted by Rajani Karuturi <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/#review62955
-----------------------------------------------------------
Ship it!
Ship It!
- Rajani Karuturi
On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20518/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:06 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6465
> https://issues.apache.org/jira/browse/CLOUDSTACK-6465
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5
> server/src/com/cloud/configuration/Config.java 5ac0e90
>
> Diff: https://reviews.apache.org/r/20518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is
missing from cluster level settings
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/#review63214
-----------------------------------------------------------
Hi Hari, should we backport this to 4.3? If yes, please send a patch. Thanks.
- Rohit Yadav
On Nov. 25, 2014, 6:06 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20518/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:06 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6465
> https://issues.apache.org/jira/browse/CLOUDSTACK-6465
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5
> server/src/com/cloud/configuration/Config.java 5ac0e90
>
> Diff: https://reviews.apache.org/r/20518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is
missing from cluster level settings
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/
-----------------------------------------------------------
(Updated Nov. 25, 2014, 6:06 a.m.)
Review request for cloudstack, Kishan Kavala and Rajani Karuturi.
Bugs: CLOUDSTACK-6465
https://issues.apache.org/jira/browse/CLOUDSTACK-6465
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5
server/src/com/cloud/configuration/Config.java 5ac0e90
Diff: https://reviews.apache.org/r/20518/diff/
Testing
-------
Thanks,
Harikrishna Patnala