You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/10 01:06:00 UTC
[jira] [Work logged] (BEAM-6184) PortableRunner dependency missed
in wordcount example maven artifact
[ https://issues.apache.org/jira/browse/BEAM-6184?focusedWorklogId=183473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183473 ]
ASF GitHub Bot logged work on BEAM-6184:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/19 01:05
Start Date: 10/Jan/19 01:05
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7454: [BEAM-6184] Enforce javadoc check on non-trivial public methods
URL: https://github.com/apache/beam/pull/7454
This PR includes:
1) Enforce javadoc checkstyle rules on public non-trivial (> 30Loc) methods.
2) added an exmaple of @SuppressWarnings("checkstyle:JavadocMethod") in BeamTableUtils.java
3) Removed a few compiler suppresses that no longer needed (and do not work with checkstyle's naming convention).
In this PR the violations are shown as warnings, for following step, we could either
a) keep them as warnings, and switch to error when all are addressed (either adding comment or suppress).
b) change them into errors, and add explicit suppression rules to all violations. Contributors eliminate and chop off these violations over time.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [X ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 183473)
Time Spent: 40m (was: 0.5h)
> PortableRunner dependency missed in wordcount example maven artifact
> --------------------------------------------------------------------
>
> Key: BEAM-6184
> URL: https://issues.apache.org/jira/browse/BEAM-6184
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
>
>
> more context: https://lists.apache.org/thread.html/8dd60395424425f7502d62888c49014430d1d3b06c026606f3db28ab@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)