You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 12:38:44 UTC

[GitHub] [arrow] cjermain opened a new pull request, #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path

cjermain opened a new pull request, #12675:
URL: https://github.com/apache/arrow/pull/12675

   This PR adds support for the home directory in paths. This fixes a problem where `pyarrow.parquet.read_table` fails to find files relative to the home directory. 
   
   I added `os.path.expanduser` to the `_stringify_path` function to have the widest effect with minimal changes. Happy to adjust that if there is a better place.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] jorisvandenbossche closed pull request #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path
URL: https://github.com/apache/arrow/pull/12675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] jorisvandenbossche closed pull request #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path
URL: https://github.com/apache/arrow/pull/12675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12675:
URL: https://github.com/apache/arrow/pull/12675#issuecomment-1089873514

   Benchmark runs are scheduled for baseline = 0015561b35f413c4b6c7309f2f86a845860c6e7f and contender = bdb5ab893e2f4886b9ac00b4dd3116928bf269b0. bdb5ab893e2f4886b9ac00b4dd3116928bf269b0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6d56d1118f244f498daa0a4d6d941756...551202d405d343ff9b04c0043817f007/)
   [Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2332874be9d4b46a647f3b6d0cb23f2...5292fd5d0fae4a7f8391e36a1348fe6b/)
   [Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e7acb571893747c8b9d29f2c8734bb56...a88a009f96144c3fb4d4d42eaf99c4f7/)
   [Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/aa4aa1a1fcaf4911afda0f91ae1148e3...14c06611a52442e2b34bfd7e7e91dc92/)
   Buildkite builds:
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/448| `bdb5ab89` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/433| `bdb5ab89` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/434| `bdb5ab89` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/443| `bdb5ab89` ursa-thinkcentre-m75q>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/447| `0015561b` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/432| `0015561b` test-mac-arm>
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/433| `0015561b` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/442| `0015561b` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] jorisvandenbossche commented on pull request #12675: ARROW-15982: [Python] parquet.read_table fails to parse home directory path

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #12675:
URL: https://github.com/apache/arrow/pull/12675#issuecomment-1088653066

   @cjermain sorry for the slow follow-up. It seems fine to support this, and since it is done inside `_stringify_path`, which is used in `_resolve_filesystem_and_path`, it should automatically work in all places where we handle paths/filesystems. 
   
   Thanks for the contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org